Closed Bug 1383841 Opened 2 years ago Closed 2 years ago

[Mac] Disable sandbox violation logging by default

Categories

(Core :: Security: Process Sandboxing, defect)

56 Branch
Unspecified
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: haik, Assigned: haik)

References

Details

Attachments

(1 file)

This bug is to disable our sandbox violation logging on Nightly. This means changing the default value of pref "security.sandbox.logging.enabled" to be false. The logging is still available for debugging by reverting that pref to be true. On Beta and Release, the value is already false. This affects the messages logged to Console.app from sandboxd.
(In reply to Haik Aftandilian [:haik] from comment #0)
> On Beta and Release, the value is already false.

That's incorrect. It's true for all releases at the moment.
Summary: [Mac] Disable sandbox violation logging by default on Nightly → [Mac] Disable sandbox violation logging by default
With this change, the sandbox logging can still be enabled by setting the environment variable MOZ_SANDBOX_LOGGING.
Assignee: nobody → haftandilian
Comment on attachment 8889579 [details]
Bug 1383841 - [Mac] Disable sandbox violation logging by default.

https://reviewboard.mozilla.org/r/160602/#review165870
Comment on attachment 8889579 [details]
Bug 1383841 - [Mac] Disable sandbox violation logging by default.

https://reviewboard.mozilla.org/r/160602/#review165872
Attachment #8889579 - Flags: review?(agaynor) → review+
Pushed by haftandilian@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6981ac43cc15
[Mac] Disable sandbox violation logging by default. r=Alex_Gaynor
See Also: → 1338651
This also brought some improvements on osx-10-10 platform:

== Change summary for alert #8195 (as of July 24 2017 20:01 UTC) ==

Improvements:

 20%  damp summary osx-10-10 opt e10s     329.13 -> 261.93
  6%  tps summary osx-10-10 opt e10s      22.21 -> 20.78

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=8195
(In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #7)
> This also brought some improvements on osx-10-10 platform:
> 
> == Change summary for alert #8195 (as of July 24 2017 20:01 UTC) ==
> 
> Improvements:
> 
>  20%  damp summary osx-10-10 opt e10s     329.13 -> 261.93
>   6%  tps summary osx-10-10 opt e10s      22.21 -> 20.78
> 
> For up to date results, see:
> https://treeherder.mozilla.org/perf.html#/alerts?id=8195

This is likely related to the issue described in bug 1338651 where a sandbox violation, when logged by sandboxd, causes sandboxd to attempt to symbolicate numerous object files using invalid paths. With bug 1338651, the paths are for files in /home which triggers automount activity. See bug 1338651 for more details, especially comment 147 and later: <https://bugzilla.mozilla.org/show_bug.cgi?id=1338651#c147>
https://hg.mozilla.org/mozilla-central/rev/6981ac43cc15
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
massive perf improvements here:
== Change summary for alert #8225 (as of July 24 2017 20:27 UTC) ==

Improvements:

 93%  bloom_basic summary osx-10-10 opt e10s     34.27 -> 2.41
 23%  ts_paint_webext osx-10-10 opt e10s         1,388.00 -> 1,064.25
 21%  ts_paint osx-10-10 opt e10s                1,245.58 -> 981.00
 21%  tcanvasmark summary osx-10-10 opt e10s     6,300.38 -> 7,629.58
 21%  a11yr summary osx-10-10 opt e10s           511.48 -> 404.17
 21%  kraken summary osx-10-10 opt e10s          1,849.23 -> 1,464.20
 19%  sessionrestore_many_windows osx-10-10 opt e10s3,859.92 -> 3,117.92
 19%  tp5o_webext summary osx-10-10 opt e10s     317.90 -> 257.59
 17%  tart summary osx-10-10 opt e10s            12.12 -> 10.09
 14%  tscrollx summary osx-10-10 opt e10s        3.75 -> 3.24
 12%  tsvg_static summary osx-10-10 opt e10s     63.58 -> 56.24
 11%  glvideo Mean tick time across 100 ticks:  osx-10-10 opt e10s21.08 -> 18.72
  9%  tresize osx-10-10 opt e10s                 30.48 -> 27.82
  8%  tpaint summary osx-10-10 opt e10s          340.82 -> 312.59
  7%  dromaeo_css summary osx-10-10 opt e10s     8,551.12 -> 9,122.49

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=8225
See Also: → 1306244
Duplicate of this bug: 1376143
You need to log in before you can comment on or make changes to this bug.