Open
Bug 1383887
Opened 7 years ago
Updated 2 years ago
Icon colors don't update until restart when changing the Windows accent color
Categories
(Firefox :: Theme, defect, P3)
Tracking
()
NEW
People
(Reporter: bwinton, Unassigned)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
5.91 MB,
image/jpeg
|
Details |
For some accent colours on Windows 10, we have black text on the background tabs, but white icons. It looks odd to me. :)
Reporter | ||
Comment 1•7 years ago
|
||
Note: I've seen it on medium oranges, greens, and greys. I can't get the exact hex value, because when I focus the browser toolbox to try and get it, it deactivates the window, thus changing the color.
Reporter | ||
Comment 2•7 years ago
|
||
Oh! I took a delayed screenshot (at https://cl.ly/2P3P1w0Q3Y2H ), and from that, one of the colours that triggers it looks to be #8C8C8C!
Comment 3•7 years ago
|
||
I think this will be fixed in the new tab design coming in bug 1349555 (at least I assumed that reviewing bug 1196266). We could keep this open to track the issue either way.
Comment 4•7 years ago
|
||
Can you reproduce in the latest nightly (with bug 1379266 fixed) and when restarting Firefox after changing any Windows settings?
Flags: needinfo?(bwinton)
Updated•7 years ago
|
Flags: qe-verify+
Priority: -- → P2
QA Contact: brindusa.tot
Whiteboard: [photon-visual][triage] → [photon-visual]
Updated•7 years ago
|
Whiteboard: [photon-visual] → [photon-visual][p1]
Comment 6•7 years ago
|
||
Ah, for me the problem is that it's not updating the icon color in windows that were open while the accent color was updated, it has the correct color if you open a new window. That is quite strange, since the accent color text updates correctly. Jonathan, any idea about that?
Flags: needinfo?(jwatt)
Flags: needinfo?(jhofmann)
Flags: needinfo?(bwinton)
Comment 7•7 years ago
|
||
That's likely due to ToolbarIconColor.inferFromText not being called. Also, bug 1372689 should solve this for the new tab, all tabs and scroll buttons.
Flags: needinfo?(jwatt)
Priority: P2 → P3
Summary: Text colour on background tabs doesn't match colour of icons. → Icon colors don't update until restart when changing the Windows accent color
Whiteboard: [photon-visual][p1] → [reserve-photon-visual][p3]
Reporter | ||
Comment 9•7 years ago
|
||
Mostly, I think? After changing my background a bunch, I just saw it (but oddly only in one of my two windows)… https://cl.ly/2l3i2c2q372x Huh, weirder still, if I create enough tabs to show the dropdown, then the + turns from white to black!
Flags: needinfo?(bwinton)
Reporter | ||
Comment 10•7 years ago
|
||
And again this morning: https://cl.ly/353E2R0V0U2l
Updated•7 years ago
|
Priority: P3 → P4
Updated•7 years ago
|
Flags: qe-verify+
Priority: P4 → P3
QA Contact: brindusa.tot
Whiteboard: [reserve-photon-visual][p3]
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•