1383919 - Avoid "dynamic exception specifications are deprecated in C++11" warning with GCC 7

Status: RESOLVED FIXED

(Core :: Memory Allocator, defect)

Description

[Botond Ballo [:botond] [away until Jun 24]]

When building trunk with GCC 7, I see warnings like this:

 0:17.55 /home/botond/dev/projects/mozilla/central/obj-x86_64-pc-linux-gnu/dist/include/mozilla/mozalloc.h:180:52: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
 0:17.55  #define MOZALLOC_THROW_BAD_ALLOC_IF_HAS_EXCEPTIONS throw(std::bad_alloc)
 0:17.55                                                     ^
 0:17.55 /home/botond/dev/projects/mozilla/central/obj-x86_64-pc-linux-gnu/dist/include/mozilla/mozalloc.h:183:34: note: in expansion of macro ‘MOZALLOC_THROW_BAD_ALLOC_IF_HAS_EXCEPTIONS’
 0:17.55  #define MOZALLOC_THROW_BAD_ALLOC MOZALLOC_THROW_BAD_ALLOC_IF_HAS_EXCEPTIONS
 0:17.55                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 0:17.55 /home/botond/dev/projects/mozilla/central/obj-x86_64-pc-linux-gnu/dist/include/mozilla/mozalloc.h:192:33: note: in expansion of macro ‘MOZALLOC_THROW_BAD_ALLOC’
 0:17.55  void* operator new(size_t size) MOZALLOC_THROW_BAD_ALLOC
 0:17.55                                  ^~~~~~~~~~~~~~~~~~~~~~~~
 
Basically, we are using |throw(std::bad_alloc)|, but dynamic exception specifications have been deprecated in C++11. The C++11 equivalent is |noexcept(false)|.

It should be straightforward to use |noexcept(false)| when appropriate.

Comment 1

[Botond Ballo [:botond] [away until Jun 24]]

Attachment: Bug 1383919 - Use |noexcept| instead of an exception-specification in mozalloc.h.

Review commit: https://reviewboard.mozilla.org/r/160754/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/160754/

Comment 2

[Mike Hommey [:glandium] OoO until Jun 18]

Comment on attachment 8889692 [details]
Bug 1383919 - Use |noexcept| instead of an exception-specification in mozalloc.h.

https://reviewboard.mozilla.org/r/160754/#review168650

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae7e3082d862
Use |noexcept| instead of an exception-specification in mozalloc.h. r=glandium

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ae7e3082d862