Closed
Bug 1384042
Opened 7 years ago
Closed 3 years ago
Don't inline functions when the call has an empty type barrier
Categories
(Core :: JavaScript Engine: JIT, enhancement, P3)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
INVALID
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
3.07 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
Sometimes we inline a function even though the call has an empty type barrier and we know the caller will be invalidated as soon as the inlined function "returns".
Attachment #8889811 -
Flags: review?(bhackett1024)
Updated•7 years ago
|
Attachment #8889811 -
Flags: review?(bhackett1024) → review+
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1455629cb663 Don't Ion-inline functions when the call has an empty type barrier. r=bhackett
Comment 2•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1455629cb663
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Assignee | ||
Comment 3•7 years ago
|
||
I might have regressed AngularJS-TodoMVC-CompletingAllItems-sync by 50% . I'll take a look.
Flags: needinfo?(jdemooij)
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Jan de Mooij [:jandem] from comment #3) > I might have regressed AngularJS-TodoMVC-CompletingAllItems-sync by 50% . > I'll take a look. I backed this out for now: https://hg.mozilla.org/integration/mozilla-inbound/rev/91c459dd13e5d05cd5b707ae717801a6b04d6031 This patch actually did the right thing (not inlining a function in a branch that was never taken), but it did affect some other inlining heuristics that I think are broken. I'll get back to this soon.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 5•7 years ago
|
||
backout bugherder |
backed out from m-c https://hg.mozilla.org/mozilla-central/rev/91c459dd13e5
Updated•7 years ago
|
Priority: -- → P2
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(jdemooij)
Priority: P2 → P3
Assignee | ||
Updated•6 years ago
|
status-firefox56:
fixed → ---
Target Milestone: mozilla56 → ---
Comment 6•3 years ago
|
||
Old, TI related bug. No longer valid with Warp.
Status: REOPENED → RESOLVED
Closed: 7 years ago → 3 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•