1384042 - Don't inline functions when the call has an empty type barrier

Status: RESOLVED INVALID

(Core :: JavaScript Engine: JIT, enhancement, P3)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

Sometimes we inline a function even though the call has an empty type barrier and we know the caller will be invalidated as soon as the inlined function "returns".

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1455629cb663
Don't Ion-inline functions when the call has an empty type barrier. r=bhackett

Comment 2

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1455629cb663

Comment 3

[Jan de Mooij [:jandem]]

I might have regressed AngularJS-TodoMVC-CompletingAllItems-sync by 50% . I'll take a look.

Comment 4

[Jan de Mooij [:jandem]]

(In reply to Jan de Mooij [:jandem] from comment #3)
> I might have regressed AngularJS-TodoMVC-CompletingAllItems-sync by 50% .
> I'll take a look.

I backed this out for now:

https://hg.mozilla.org/integration/mozilla-inbound/rev/91c459dd13e5d05cd5b707ae717801a6b04d6031

This patch actually did the right thing (not inlining a function in a branch that was never taken), but it did affect some other inlining heuristics that I think are broken.

I'll get back to this soon.

Comment 5

[Carsten Book [:Tomcat]]

backed out from m-c
https://hg.mozilla.org/mozilla-central/rev/91c459dd13e5

Comment 6

[André Bargull [:anba]]

Old, TI related bug. No longer valid with Warp.