1384056 - The keyboard is dismissed when opening a new tab via Today Widget while in tabs tray

Status: NEW

(Firefox for iOS :: General, defect, P3)

Description

[Simon Basca [:SimonB]]

Build: 35383ea543
Device: iPhone 6S
iOS: 10.3.3

Steps to reproduce:
1. Launch Firefox 
2. Open tabs tray
3. Open a new tab via Today Widget

Actual results:
- The URL bar will be focused but the keyboard is immediately dismissed. 

See video:
- https://www.youtube.com/watch?v=0kmuxEVwrok

Comment 1

[:garvan]

need info me: check if this is related to focusing the URL bar on new tab

Comment 2

[:garvan]

Attachment: Pull request

Comment 3

[:garvan]

Clearing my hacky patch, there are some likely culprits that are causing this behaviour:

See notes here: https://github.com/mozilla-mobile/firefox-ios/pull/3006#issuecomment-320317642
"""
 We should instead try to figure out what is removing focus and stop that from happening.
When opening a newtab we call popToBVC sometimes. This calls leaveOverlayMode which will resign first responder.

There is probably some method that is being called to setup/clear the state that is resigningFirstResponder when a new tab is created.
"""