Closed
Bug 1384057
Opened 7 years ago
Closed 7 years ago
Stop using preprocessor in nsHelperAppDlg.js
Categories
(Toolkit :: Downloads API, enhancement)
Toolkit
Downloads API
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: marco, Assigned: marco)
References
Details
Attachments
(1 file, 1 obsolete file)
3.41 KB,
patch
|
Paolo
:
review+
|
Details | Diff | Splinter Review |
The preprocessor is only used to distinguish GTK3 vs GTK2 builds.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #8889887 -
Flags: review?(paolo.mozmail)
Assignee | ||
Comment 2•7 years ago
|
||
Green on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=daf336139396b79bec7d6371e9b79b2ffa1a8723.
Assignee | ||
Comment 3•7 years ago
|
||
Reordered entries in moz.build in alphabetical order to avoid build error.
Attachment #8889887 -
Attachment is obsolete: true
Attachment #8889887 -
Flags: review?(paolo.mozmail)
Attachment #8890046 -
Flags: review?(paolo.mozmail)
Updated•7 years ago
|
Attachment #8890046 -
Flags: review?(paolo.mozmail) → review+
Pushed by mcastelluccio@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/68a7ead060bf Stop using preprocessor in nsHelperAppDlg.js. r=paolo
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/68a7ead060bf
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•