Closed Bug 1384057 Opened 2 years ago Closed 2 years ago

Stop using preprocessor in nsHelperAppDlg.js

Categories

(Toolkit :: Downloads API, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(1 file, 1 obsolete file)

The preprocessor is only used to distinguish GTK3 vs GTK2 builds.
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #8889887 - Flags: review?(paolo.mozmail)
Attached patch PatchSplinter Review
Reordered entries in moz.build in alphabetical order to avoid build error.
Attachment #8889887 - Attachment is obsolete: true
Attachment #8889887 - Flags: review?(paolo.mozmail)
Attachment #8890046 - Flags: review?(paolo.mozmail)
Attachment #8890046 - Flags: review?(paolo.mozmail) → review+
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/68a7ead060bf
Stop using preprocessor in nsHelperAppDlg.js. r=paolo
https://hg.mozilla.org/mozilla-central/rev/68a7ead060bf
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.