Closed Bug 1384087 Opened 3 years ago Closed 3 years ago

Privacy & Security - Address bar - first option should be Browsing history

Categories

(Firefox :: Preferences, defect, P1)

56 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 56
Tracking Status
firefox54 --- unaffected
firefox55 --- unaffected
firefox56 --- verified

People

(Reporter: brindusat, Assigned: rickychien)

References

Details

(Whiteboard: [photon-preference])

Attachments

(2 files)

[Affected versions]: 
Nightly 56.0a1, Build ID 20170724030204

[Affected platforms]:
Platforms: Windows 10 x 64, Mac OS X 10.12, Ubuntu 

[Steps to reproduce]:
1. Launch Nightly
2. Go to "about:preferences".
3. In the Privacy & Security tab and check "Address Bar" section

[Expected result]:
The first option under Address Bar section should be "Browsing history" per spec:
 https://mozilla.invisionapp.com/share/P4ACQT1E3#/screens/237159280.
See attached screenshot from specs

[Actual result]:
The first option under Address Bar section is  "History".
Whiteboard: [photon-preference][triage]
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Flags: qe-verify+
Priority: -- → P1
Target Milestone: --- → Firefox 56
QA Contact: hani.yacoub
Whiteboard: [photon-preference][triage] → [photon-preference]
Comment on attachment 8890150 [details]
Bug 1384087 - Address bar's first option should be Browsing history

https://reviewboard.mozilla.org/r/161234/#review166764

::: browser/locales/en-US/chrome/browser/preferences/privacy.dtd:38
(Diff revision 2)
> -<!ENTITY  locbar.history.label          "History">
> +<!ENTITY  locbar.history2.label         "Browsing history">
>  <!ENTITY  locbar.history.accesskey      "H">

The accesskey entity name needs to get updated too.
Attachment #8890150 - Flags: review?(jaws) → review-
Comment on attachment 8890150 [details]
Bug 1384087 - Address bar's first option should be Browsing history

https://reviewboard.mozilla.org/r/161234/#review167572
Attachment #8890150 - Flags: review?(jaws) → review+
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b5c8ed2fc610
Address bar's first option should be Browsing history r=jaws
https://hg.mozilla.org/mozilla-central/rev/b5c8ed2fc610
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Tested on Windows 10, Mac OS X 10.12 and Ubuntu 16.04 with FF Nightly 56.0a1(2017-07-30). I will mark this as Verified Fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.