1384087 - Privacy & Security - Address bar - first option should be Browsing history

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Brindusa Tot, Desktop QA]

Attachment: BrowsingHistoryOption.jpg

[Affected versions]: 
Nightly 56.0a1, Build ID 20170724030204

[Affected platforms]:
Platforms: Windows 10 x 64, Mac OS X 10.12, Ubuntu 

[Steps to reproduce]:
1. Launch Nightly
2. Go to "about:preferences".
3. In the Privacy & Security tab and check "Address Bar" section

[Expected result]:
The first option under Address Bar section should be "Browsing history" per spec:
 https://mozilla.invisionapp.com/share/P4ACQT1E3#/screens/237159280.
See attached screenshot from specs

[Actual result]:
The first option under Address Bar section is  "History".

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1384087 - Address bar's first option should be Browsing history

Review commit: https://reviewboard.mozilla.org/r/161234/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/161234/

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8890150 [details]
Bug 1384087 - Address bar's first option should be Browsing history

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161234/diff/1-2/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8890150 [details]
Bug 1384087 - Address bar's first option should be Browsing history

https://reviewboard.mozilla.org/r/161234/#review166764

::: browser/locales/en-US/chrome/browser/preferences/privacy.dtd:38
(Diff revision 2)
> -<!ENTITY  locbar.history.label          "History">
> +<!ENTITY  locbar.history2.label         "Browsing history">
>  <!ENTITY  locbar.history.accesskey      "H">

The accesskey entity name needs to get updated too.

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8890150 [details]
Bug 1384087 - Address bar's first option should be Browsing history

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161234/diff/2-3/

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8890150 [details]
Bug 1384087 - Address bar's first option should be Browsing history

https://reviewboard.mozilla.org/r/161234/#review167572

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8890150 [details]
Bug 1384087 - Address bar's first option should be Browsing history

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161234/diff/3-4/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5c8ed2fc610
Address bar's first option should be Browsing history r=jaws

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b5c8ed2fc610

Comment 9

[Deac Alin]

Tested on Windows 10, Mac OS X 10.12 and Ubuntu 16.04 with FF Nightly 56.0a1(2017-07-30). I will mark this as Verified Fixed.