Closed
Bug 1384168
Opened 7 years ago
Closed 7 years ago
Invalid address freeze tab after losing focus
Categories
(Core :: DOM: Navigation, defect, P1)
Tracking
()
VERIFIED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | verified |
People
(Reporter: olivier.haremza, Assigned: freesamael)
References
Details
(Keywords: nightly-community)
Attachments
(2 files, 1 obsolete file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36 Steps to reproduce: 1. Open new tab and try the url `about:pref`. It display an error page telling that the address is invalid. 2. Open a second tab and type the url `google.com` (this step matters somehow) 3. Try clicking the first tab to display it. 4. Open a third tab and type the url `about:pref` 5. Open a fourth tab and type the url `schemenotregistered:test` Actual results: The first and third tab cannot be display anymore. Clicking on them do nothing. The fourth tab with the weird scheme is clickable but only display a spinning wheel. Note that the google search html is available in the inspect tool. Expected results: The first and third tab should not be frozen and they should display the error page saying that the address is invalid. The fourth tab should display the google search page with this weird string `schemenotregistered:test`.
Reporter | ||
Comment 1•7 years ago
|
||
Reporter | ||
Updated•7 years ago
|
Keywords: nightly-community
Updated•7 years ago
|
Component: Untriaged → Document Navigation
Product: Firefox → Core
Summary: nightly-community Invalid address freeze tab after losing focus → Invalid address freeze tab after losing focus
Comment 2•7 years ago
|
||
I find this is really annoying and results in unexpected infinite spinning. Samael, do you know what could be wrong?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(sawang)
Priority: -- → P2
Assignee | ||
Comment 3•7 years ago
|
||
This is so broken that I think it's even worth considering a P1 bug.
Assignee: nobody → sawang
Flags: needinfo?(sawang)
Comment 4•7 years ago
|
||
(In reply to Samael Wang [:freesamael] from comment #3) > This is so broken that I think it's even worth considering a P1 bug. happy to take the suggestion!
Priority: P2 → P1
Assignee | ||
Comment 5•7 years ago
|
||
mozregression gives me bug 1381569, but that only implies there's a bug behide this. Not as helping as I wish :/ https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b8f66d5a9748677dfa266a3d143525da071b730e&tochange=87e8ccdd8aa6f6b549922b4debc19a4126b7d940
Assignee | ||
Comment 6•7 years ago
|
||
It seems an invalid about URI can cause exception in tabbrowser._isLocalAboutURI. However I don't understand how this is related to activity-steam...
Comment 7•7 years ago
|
||
(In reply to Samael Wang [:freesamael] from comment #6) > Created attachment 8891297 [details] [diff] [review] > It seems an invalid about URI can cause exception in > tabbrowser._isLocalAboutURI. However I don't understand how this is related > to activity-steam... mconley and I added that `_isLocalAboutURI` to support activity-stream running in the content process.
Comment 8•7 years ago
|
||
Comment on attachment 8891297 [details] [diff] [review] Handle invalid aURI in _isLocalAboutURI Thanks for tracking this down!
Attachment #8891297 -
Flags: review+
Comment 9•7 years ago
|
||
To provide a little bit more context, bug 1365643 forces about:newtab to the content process only when activity-stream.enabled pref is turned on. Bug 1374768 fixed a bug before activity-stream was preffed on, but apparently introduces this bug. Bug 1381569 actually turned on activity stream.
Comment 10•7 years ago
|
||
With Bug 1374768, I added browser/base/content/test/tabs/browser_isLocalAboutURI.js if you could add a test to make sure it doesn't throw. freesamael, if you put it on mozreview with the test, I can click the autoland (and r+) :)
Flags: needinfo?(sawang)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 12•7 years ago
|
||
I think we do want to land this soon so it gets merged to next beta branch.
Flags: needinfo?(sawang)
Assignee | ||
Updated•7 years ago
|
Attachment #8891297 -
Attachment is obsolete: true
Assignee | ||
Comment 13•7 years ago
|
||
Thanks for reviewing BTW, I didn't expect the patch would be notcied and get reviewed :)
Comment 14•7 years ago
|
||
mozreview-review |
Comment on attachment 8891397 [details] Bug 1384168 - Handle invalid aURI in _isLocalAboutURI. https://reviewboard.mozilla.org/r/162568/#review167856
Attachment #8891397 -
Flags: review?(edilee) → review+
Comment 15•7 years ago
|
||
Pushed by edilee@gmail.com: https://hg.mozilla.org/integration/autoland/rev/e2c06426fc2e Handle invalid aURI in _isLocalAboutURI. r=Mardak
Comment 16•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e2c06426fc2e
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Updated•7 years ago
|
Flags: qe-verify+
Comment 17•7 years ago
|
||
I reproduced this issue using STR from comment 0, using an affected Nightly build. This is not repro anymore on 56 Beta 5 (20170821193225) across platforms: Windows 10 x64, Ubuntu 16.04 x64, Mac OS X 10.11.6.
You need to log in
before you can comment on or make changes to this bug.
Description
•