1384258 - stylo: build Stylo (pref'd off) in developers' local builds (on Win32, Win64, Mac, and Linux64)

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement, P1)

Description

[Chris Peterson [:cpeterson]]

We already build Stylo (pref'd) by default in automation for Win32, Win64, Mac, and Linux64. Now that the Mac clang issues have been mostly resolved, we can also build Stylo in developers' local builds (for Win32, Win64, Mac, and Linux64). We can't build on Linux32 (in automation or local builds) until some bindgen issues are resolved in bug 1366050.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Bug 1384258 - Build Stylo by default.

Build Stylo (the styling system from servo) by default in all
builds for win32, win64, macOS and linux64 targets. It was
previously enabled for automation builds, so this just changes
the behaviour for local developer builds.

Note that this introduces a new dependency on libclang for the
binding generator. If you're developing on a tier-1 platform,
run `./mach boostrap` to install a working copy. Otherwise
llvm+libclang 4.0.1 is recommended.

Remove the explicit --enable-stylo=build in mozconfig.stylo
in favour of the configure default.

Based on a patch by Bobby Holly in bug 1356991.

Review commit: https://reviewboard.mozilla.org/r/161144/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/161144/

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8890076 [details]
Bug 1384258 - Build Stylo by default.

https://reviewboard.mozilla.org/r/161144/#review166548

Comment 3

[Ralph Giles (:rillian)]

Thanks. The Hazard build needs a mozconfig.stylo include.

Comment 4

[Ralph Giles (:rillian)]

Comment on attachment 8890076 [details]
Bug 1384258 - Build Stylo by default.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161144/diff/1-2/

Comment 5

[Ralph Giles (:rillian)]

Attachment: Bug 1384258 - Ease the hazard tolerance for stylo.

Allow an extra heap write hazard introduced by enabling stylo
in default builds until it can be addressed. See bug 1384625.

Review commit: https://reviewboard.mozilla.org/r/161668/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/161668/

Comment 6

[Ralph Giles (:rillian)]

Comment on attachment 8890076 [details]
Bug 1384258 - Build Stylo by default.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161144/diff/2-3/

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8890528 [details]
Bug 1384258 - Ease the hazard tolerance for stylo.

https://reviewboard.mozilla.org/r/161668/#review167264

Comment 8

[Mozilla Autoland]

hg error in cmd: hg pull gecko -r 0d735758919ba265cf95a48a8f3e3ae68b9f4300: pulling from https://reviewboard-hg.mozilla.org/gecko
abort: HTTP Error 500: Internal Server Error

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b18177e6556b
Build Stylo by default. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/274db82383c0
Ease the hazard tolerance for stylo. r=xidorn

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b18177e6556b
https://hg.mozilla.org/mozilla-central/rev/274db82383c0

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1d94ab93b253
Keep build files in sync (port bug 1384258: Build Stylo by default). rs=bustage-fix