1384273 - Get root of tree from mach when linting.

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Tom Prince [:tomprince]]

I'd like to run `mach lint` in a subdirectory but it default to expecting the current directory as the root of the source tree. `mach` already knows where the root of the tree is, so pass that into lint, rather then letting lint guess.

Comment 1

[Tom Prince [:tomprince]]

Attachment: Bug 1384273 - Get lint root dir from mach;

Review commit: https://reviewboard.mozilla.org/r/161104/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/161104/

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 8890119 [details]
Bug 1384273 - Get lint root dir from mach;

https://reviewboard.mozilla.org/r/161104/#review166716

::: tools/lint/mach_commands.py:40
(Diff revision 1)
>          description='Run linters.',
>          parser=setup_argument_parser)
>      def lint(self, *runargs, **lintargs):
>          """Run linters."""
>          from mozlint import cli
> +        lintargs.setdefault('root', self.topsrcdir)

This should already be in lintargs:
https://dxr.mozilla.org/mozilla-central/source/python/mozlint/mozlint/roller.py#75

Specifically self.vcs.root should point to topsrcdir. In fact, the value here is being overwritten by the one above.

The lintargs are pretty opaque at the moment :(.. they should at least be documented somewhere.

Comment 3

[Tom Prince [:tomprince]]

Comment on attachment 8890119 [details]
Bug 1384273 - Get lint root dir from mach;

https://reviewboard.mozilla.org/r/161104/#review166716

> This should already be in lintargs:
> https://dxr.mozilla.org/mozilla-central/source/python/mozlint/mozlint/roller.py#75
> 
> Specifically self.vcs.root should point to topsrcdir. In fact, the value here is being overwritten by the one above.
> 
> The lintargs are pretty opaque at the moment :(.. they should at least be documented somewhere.

My specific use case is running from a comm-central repository sitting inside of a mozillla-central repository. In that case, `self.vcs.root` points at the root of comm-central, which is wrong for at least https://dxr.mozilla.org/mozilla-central/source/tools/lint/eslint/setup_helper.py#351 which is what I was trying to fix.

Looking at the places that use `lintargs['root']`, I think all of them expect it to be the root of mozilla-central.

Comment 4

[Andrew Halberstadt [:ahal]]

Comment on attachment 8890119 [details]
Bug 1384273 - Get lint root dir from mach;

https://reviewboard.mozilla.org/r/161104/#review166716

> My specific use case is running from a comm-central repository sitting inside of a mozillla-central repository. In that case, `self.vcs.root` points at the root of comm-central, which is wrong for at least https://dxr.mozilla.org/mozilla-central/source/tools/lint/eslint/setup_helper.py#351 which is what I was trying to fix.
> 
> Looking at the places that use `lintargs['root']`, I think all of them expect it to be the root of mozilla-central.

Ah, thanks for clarifying! In that case yes, this is fine.

Comment 5

[Andrew Halberstadt [:ahal]]

Comment on attachment 8890119 [details]
Bug 1384273 - Get lint root dir from mach;

https://reviewboard.mozilla.org/r/161104/#review166928

Comment 6

[Tom Prince [:tomprince]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d1c35b1ed46320e05e57b8fd55ef6e98a673b41

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8954e1ad4d82
Get lint root dir from mach; r=ahal

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8954e1ad4d82