Closed Bug 1384309 Opened 2 years ago Closed 2 years ago
about:support "Graphics" section breaks when "webgl
.disable-extensions" is true
730 bytes, patch
|Details | Diff | Splinter Review|
In Tor Browser, we found the graphics section was not getting display in the about:support page, and we saw the following error in the console: Troubleshoot data provider failed: graphics TypeError: loseExt is null Troubleshoot.jsm:164 snapshot resource://gre/modules/Troubleshoot.jsm:164:9 onload chrome://global/content/aboutSupport.js:23:3 TypeError: invalid 'in' operand data aboutSupport.js:279:1 (see https://trac.torproject.org/21972 for original ticket)
To clarify I can reproduce this in standard Firefox by setting "webgl.disable-extensions" to true. Updating title to reflect that.
Summary: Graphics section missing in Tor Browser about:support → about:support "Graphics" section breaks when "webgl.disable-extensions" is true
Here's the Tor Browser patch rebased to the latest mozilla-central. try results: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b6a131882e6
Attachment #8890103 - Flags: review?(jmuizelaar)
Comment on attachment 8890103 [details] [diff] [review] 0001-Bug-21972-about-support-is-partially-broken.patch Review of attachment 8890103 [details] [diff] [review]: ----------------------------------------------------------------- I'd drop the comment to "This extension is not necessarily available."
Attachment #8890103 - Flags: review?(jmuizelaar) → review+
I forgot to check this in earlier, but the bug and patch haven't changed. Dropped comment as suggested by Jeff, and rebased to latest mozilla-central.
Attachment #8890103 - Attachment is obsolete: true
(Converting to hg-style patch.)
Attachment #8942314 - Attachment is obsolete: true
Pushed by firstname.lastname@example.org https://hg.mozilla.org/integration/mozilla-inbound/rev/bf5aca81d31bee07f3afcb621c368cea75ac5d7d Fix about:support's graphics section when 'webgl.disable-extensions' is true. r=jrmuizel
You need to log in before you can comment on or make changes to this bug.