1384309 - about:support "Graphics" section breaks when "webgl.disable-extensions" is true

Status: RESOLVED FIXED

(Firefox :: General, defect, P2)

Description

[Arthur Edelstein [:arthur]]

In Tor Browser, we found the graphics section was not getting display in the about:support page, and we saw the following error in the console:

Troubleshoot data provider failed: graphics
TypeError: loseExt is null  Troubleshoot.jsm:164
	snapshot resource://gre/modules/Troubleshoot.jsm:164:9
	onload chrome://global/content/aboutSupport.js:23:3
TypeError: invalid 'in' operand data  aboutSupport.js:279:1

(see https://trac.torproject.org/21972 for original ticket)

Comment 1

[Arthur Edelstein [:arthur]]

To clarify I can reproduce this in standard Firefox by setting  "webgl.disable-extensions" to true. Updating title to reflect that.

Comment 2

[Arthur Edelstein [:arthur]]

Attachment: 0001-Bug-21972-about-support-is-partially-broken.patch

Here's the Tor Browser patch rebased to the latest mozilla-central.

try results: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b6a131882e6

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8890103 [details] [diff] [review]
0001-Bug-21972-about-support-is-partially-broken.patch

Review of attachment 8890103 [details] [diff] [review]:
-----------------------------------------------------------------

I'd drop the comment to "This extension is not necessarily available."

Comment 4

[Arthur Edelstein [:arthur]]

Attachment: 0001-Bug-1384309-Fix-about-support-when-webgl.disable-ext.patch

I forgot to check this in earlier, but the bug and patch haven't changed. Dropped comment as suggested by Jeff, and rebased to latest mozilla-central.

Comment 5

[Arthur Edelstein [:arthur]]

Attachment: 0001-Bug-1384309-Fix-about-support-when-webgl.disable-ext.patch

(Converting to hg-style patch.)

Comment 6

[Cristina Coroiu [:ccoroiu]]

Pushed by [e-mail]
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf5aca81d31bee07f3afcb621c368cea75ac5d7d
Fix about:support's graphics section when 'webgl.disable-extensions' is true. r=jrmuizel

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/bf5aca81d31b