about:support "Graphics" section breaks when "webgl.disable-extensions" is true

RESOLVED FIXED in Firefox 59

Status

()

Firefox
General
P2
normal
RESOLVED FIXED
11 months ago
5 months ago

People

(Reporter: arthuredelstein, Assigned: arthuredelstein)

Tracking

unspecified
Firefox 59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

(Whiteboard: [tor 21972])

Attachments

(1 attachment, 2 obsolete attachments)

In Tor Browser, we found the graphics section was not getting display in the about:support page, and we saw the following error in the console:

Troubleshoot data provider failed: graphics
TypeError: loseExt is null  Troubleshoot.jsm:164
	snapshot resource://gre/modules/Troubleshoot.jsm:164:9
	onload chrome://global/content/aboutSupport.js:23:3
TypeError: invalid 'in' operand data  aboutSupport.js:279:1

(see https://trac.torproject.org/21972 for original ticket)
Assignee: nobody → arthuredelstein
To clarify I can reproduce this in standard Firefox by setting  "webgl.disable-extensions" to true. Updating title to reflect that.
Summary: Graphics section missing in Tor Browser about:support → about:support "Graphics" section breaks when "webgl.disable-extensions" is true
Created attachment 8890103 [details] [diff] [review]
0001-Bug-21972-about-support-is-partially-broken.patch

Here's the Tor Browser patch rebased to the latest mozilla-central.

try results: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b6a131882e6
Attachment #8890103 - Flags: review?(jmuizelaar)
Comment on attachment 8890103 [details] [diff] [review]
0001-Bug-21972-about-support-is-partially-broken.patch

Review of attachment 8890103 [details] [diff] [review]:
-----------------------------------------------------------------

I'd drop the comment to "This extension is not necessarily available."
Attachment #8890103 - Flags: review?(jmuizelaar) → review+

Updated

11 months ago
Priority: -- → P2
Created attachment 8942314 [details] [diff] [review]
0001-Bug-1384309-Fix-about-support-when-webgl.disable-ext.patch

I forgot to check this in earlier, but the bug and patch haven't changed. Dropped comment as suggested by Jeff, and rebased to latest mozilla-central.
Attachment #8890103 - Attachment is obsolete: true
Created attachment 8942316 [details] [diff] [review]
0001-Bug-1384309-Fix-about-support-when-webgl.disable-ext.patch

(Converting to hg-style patch.)
Attachment #8942314 - Attachment is obsolete: true
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf5aca81d31bee07f3afcb621c368cea75ac5d7d
Fix about:support's graphics section when 'webgl.disable-extensions' is true. r=jrmuizel

Comment 7

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bf5aca81d31b
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox59: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.