Closed
Bug 1384332
Opened 8 years ago
Closed 8 years ago
Share extension is called 'Share To' instead of 'Firefox'
Categories
(Firefox for iOS :: General, defect)
Tracking
()
VERIFIED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | 8.1+ | --- |
People
(Reporter: st3fan, Assigned: st3fan)
Details
(Whiteboard: [ShareTo])
Attachments
(1 file)
In 8.x, the name of the Share extension is "Share To" instead of the product name. It should have the same name as the application on the device's home screen. So Firefox for production, Fennec for development, etc.
"Share To" is also not localized.
Marking this as 8.1 since this is a big visual regression.
See also https://bugzilla.mozilla.org/show_bug.cgi?id=1355496 :-(
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8890153 -
Flags: review?(jdarcangelo)
Attachment #8890153 -
Flags: review?(fpatel)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8890153 [details] [review]
PR https://github.com/mozilla-mobile/firefox-ios/pull/2975
LGTM
Attachment #8890153 -
Flags: review?(jdarcangelo) → review+
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → sarentz
|
|
Assignee | |
Comment 3•8 years ago
|
||
This patch does not work on a localized build i think. Investigating.
|
|
Assignee | |
Comment 4•8 years ago
|
||
Landed on v8.x. Also moved to master.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•8 years ago
|
Whiteboard: [ShareTo]
|
||
Updated•8 years ago
|
Attachment #8890153 -
Flags: review?(fpatel) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•