Closed Bug 1384436 Opened 2 years ago Closed 2 years ago

Update sccache to 0.2.0

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox56 fixed)

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8890217 [details]
Bug 1384436 - Update sccache to version 0.2.0.

https://reviewboard.mozilla.org/r/161324/#review166732

I thought about this while reviewing those other patches yesterday but forgot to mention it. Thanks!

::: taskcluster/scripts/misc/build-sccache.sh:4
(Diff revision 1)
>  #!/bin/bash
>  set -x -e -v
>  
> -SCCACHE_REVISION=69334a26ba65fc88e3934271a2ce6781c51b445e
> +SCCACHE_REVISION=43300e1976bdbfc8dbda30e22a00ce2cce54e9de

You could just use the `0.2.0` tag here to be clearer, right?
Attachment #8890217 - Flags: review?(ted) → review+
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> Comment on attachment 8890217 [details]
> Bug 1384436 - Update sccache to version 0.2.0.
> 
> https://reviewboard.mozilla.org/r/161324/#review166732
> 
> I thought about this while reviewing those other patches yesterday but
> forgot to mention it. Thanks!
> 
> ::: taskcluster/scripts/misc/build-sccache.sh:4
> (Diff revision 1)
> >  #!/bin/bash
> >  set -x -e -v
> >  
> > -SCCACHE_REVISION=69334a26ba65fc88e3934271a2ce6781c51b445e
> > +SCCACHE_REVISION=43300e1976bdbfc8dbda30e22a00ce2cce54e9de
> 
> You could just use the `0.2.0` tag here to be clearer, right?

Using the full revision has the advantage that it also validates the source content. "0.2.0" could point to something else and nothing would notice.
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/be21461d6fef
Update sccache to version 0.2.0. r=ted
https://hg.mozilla.org/mozilla-central/rev/be21461d6fef
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
This introduced a bunch of compiler warnings, and lots of sccache improvements:

== Change summary for alert #8352 (as of July 26 2017 22:20 UTC) ==

Regressions:

 15%  compiler warnings summary osx-cross opt      6,062.75 -> 6,963.83
 14%  compiler warnings summary osx-cross debug    6,586.83 -> 7,478.50
 13%  compiler warnings summary linux64 asan asan opt8,766.17 -> 9,948.58
 13%  compiler warnings summary linux64 asan asan-fuzzing8,756.58 -> 9,910.25
 13%  compiler warnings summary osx-cross-noopt debug 6,821.33 -> 7,708.92
 11%  compiler warnings summary linux64 asan asan debug10,948.17 -> 12,147.58

Improvements:

 87%  sccache requests_not_cacheable summary linux64 debug base-toolchains taskcluster-c4.4xlarge     71.00 -> 9.00
 75%  sccache requests_not_cacheable summary osx-cross debug taskcluster-c4.4xlarge                   229.00 -> 57.00
 75%  sccache requests_not_cacheable summary osx-cross-noopt debug taskcluster-c4.4xlarge             229.00 -> 57.00
 75%  sccache requests_not_cacheable summary osx-cross opt taskcluster-c4.4xlarge                     227.00 -> 57.00
 73%  sccache requests_not_cacheable summary linux32 opt taskcluster-c4.4xlarge                       56.00 -> 15.00
 71%  sccache requests_not_cacheable summary android-4-2-x86 opt taskcluster-c4.2xlarge               48.00 -> 14.00
 68%  sccache requests_not_cacheable summary android-5-0-aarch64 opt taskcluster-c4.2xlarge           47.00 -> 15.00
 63%  sccache requests_not_cacheable summary linux64 opt taskcluster-c4.4xlarge                       98.00 -> 36.00
 56%  sccache requests_not_cacheable summary linux64 asan asan debug taskcluster-c4.4xlarge           64.00 -> 28.00
 50%  sccache requests_not_cacheable summary linux64 asan asan opt taskcluster-c4.4xlarge             72.00 -> 36.00

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=8352
(In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #6)
> This introduced a bunch of compiler warnings, and lots of sccache
> improvements:
> 
> == Change summary for alert #8352 (as of July 26 2017 22:20 UTC) ==
> 
> Regressions:
> 
>  15%  compiler warnings summary osx-cross opt      6,062.75 -> 6,963.83
>  14%  compiler warnings summary osx-cross debug    6,586.83 -> 7,478.50
>  13%  compiler warnings summary linux64 asan asan opt8,766.17 -> 9,948.58
>  13%  compiler warnings summary linux64 asan asan-fuzzing8,756.58 -> 9,910.25
>  13%  compiler warnings summary osx-cross-noopt debug 6,821.33 -> 7,708.92
>  11%  compiler warnings summary linux64 asan asan debug10,948.17 -> 12,147.58

As mentioned in bug 1382502, I'm working on fixing the issues that cause that in sccache.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.