Closed
Bug 1384449
Opened 7 years ago
Closed 7 years ago
when= is failing with js_option
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox56 fixed)
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
Details
Attachments
(1 file)
Translated from French <glandium> Sylvestre: it is js_option's fault <glandium> Sylvestre: the when is missing here: https://dxr.mozilla.org/mozilla-central/source/build/moz.configure/init.configure#824 <glandium> we should extract it from kwargs and give it
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8890234 [details] Bug 1384449 - Implement the support of when= for js_option https://reviewboard.mozilla.org/r/161342/#review166654 ::: build/moz.configure/init.configure:904 (Diff revision 1) > # This is temporary until js/src/configure and configure are merged. > # Use instead of option() in js/moz.configure and more generally, for > # options that are shared between configure and js/src/configure. > @template > def js_option(*args, **kwargs): > + when = kwargs['when'] if 'when' in kwargs else None kwargs.get('when') does the same thing.
Attachment #8890234 -
Flags: review?(mh+mozilla)
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8890234 [details] Bug 1384449 - Implement the support of when= for js_option https://reviewboard.mozilla.org/r/161342/#review166668 ::: build/moz.configure/init.configure:907 (Diff revision 2) > @template > def js_option(*args, **kwargs): > + when = kwargs.get('when') > opt = option(*args, **kwargs) > > - @depends(opt.option, build_project) > + @depends(opt.option, build_project, when=when) you could also just inline everything here.
Attachment #8890234 -
Flags: review?(mh+mozilla) → review+
Comment hidden (mozreview-request) |
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4093407bd0f0 Implement the support of when= for js_option r=glandium
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4093407bd0f0
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•