Closed Bug 1384478 Opened 3 years ago Closed 2 years ago

browser/base/content/test/general/browser_save_video.js fails when we enable rcwn

Categories

(Core :: Networking: Cache, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: junior, Assigned: michal)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-active])

Attachments

(1 file, 1 obsolete file)

RCWN would break the test by the following command

mach mochitest --setpref network.http.rcwn.enabled=true  browser/base/content/test/general/browser_save_video.js
Assign myself first. Feel free to take it.
Assignee: nobody → juhsu
Whiteboard: [necko-active]
"Save Video As" functional works in nightly.
Summary: "Save Video As" not working when we enable rcwn → browser/base/content/test/general/browser_save_video.js fails when we enable rcwn
Attached patch disable-rcwn-save-video, v1 (obsolete) — Splinter Review
Hello Paolo,
Since save_video_as works well in nightly with rcwn and we
don't have a fix after survey, we'd like to disable rcwn in this test.

Could you review my patch please? Thanks.
Attachment #8902633 - Flags: review?(paolo.mozmail)
Comment on attachment 8902633 [details] [diff] [review]
disable-rcwn-save-video, v1

From the looks of the test, I don't see how enabling RCWN can make the test fail, other than a race condition for which some expected progress events are not dispatched, which would be a bug in the RCWN implementation.

How did you determine that "Save Video As" works in Nightly? If you just tested it manually, it's quite possible that it only works because you wait some time before invoking the command, and maybe it would actually fail on larger videos or certain network conditions.
Attachment #8902633 - Flags: review?(paolo.mozmail) → review-
> How did you determine that "Save Video As" works in Nightly? If you just
> tested it manually, it's quite possible that it only works because you wait
> some time before invoking the command, and maybe it would actually fail on
> larger videos or certain network conditions.

Yes by manual test.
I had a look at the failure and the channel really doesn't provide any data. The problem is that the cache entry is nulled out at http://searchfox.org/mozilla-central/rev/51b3d67a5ec1758bd2fe7d7b6e75ad6b6b5da223/netwerk/protocol/http/nsHttpChannel.cpp#1722.
Attached patch fixSplinter Review
Assignee: juhsu → michal.novotny
Attachment #8902633 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8902991 - Flags: review?(honzab.moz)
Attachment #8902991 - Flags: review?(honzab.moz) → review+
Pushed by mnovotny@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1768de3e9f2
browser/base/content/test/general/browser_save_video.js fails when we enable rcwn, r=honzab
https://hg.mozilla.org/mozilla-central/rev/d1768de3e9f2
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.