1384478 - browser/base/content/test/general/browser_save_video.js fails when we enable rcwn

Status: RESOLVED FIXED

(Core :: Networking: Cache, enhancement)

Description

[Junior [inactive]]

RCWN would break the test by the following command

mach mochitest --setpref network.http.rcwn.enabled=true  browser/base/content/test/general/browser_save_video.js

Comment 1

[Junior [inactive]]

Assign myself first. Feel free to take it.

Comment 2

[Junior [inactive]]

"Save Video As" functional works in nightly.

Comment 3

[Junior [inactive]]

Attachment: disable-rcwn-save-video, v1

Hello Paolo,
Since save_video_as works well in nightly with rcwn and we
don't have a fix after survey, we'd like to disable rcwn in this test.

Could you review my patch please? Thanks.

Comment 4

[:Paolo Amadini]

Comment on attachment 8902633 [details] [diff] [review]
disable-rcwn-save-video, v1

From the looks of the test, I don't see how enabling RCWN can make the test fail, other than a race condition for which some expected progress events are not dispatched, which would be a bug in the RCWN implementation.

How did you determine that "Save Video As" works in Nightly? If you just tested it manually, it's quite possible that it only works because you wait some time before invoking the command, and maybe it would actually fail on larger videos or certain network conditions.

Comment 5

[Junior [inactive]]

> How did you determine that "Save Video As" works in Nightly? If you just
> tested it manually, it's quite possible that it only works because you wait
> some time before invoking the command, and maybe it would actually fail on
> larger videos or certain network conditions.

Yes by manual test.

Comment 6

[Michal Novotny [:michal]]

I had a look at the failure and the channel really doesn't provide any data. The problem is that the cache entry is nulled out at http://searchfox.org/mozilla-central/rev/51b3d67a5ec1758bd2fe7d7b6e75ad6b6b5da223/netwerk/protocol/http/nsHttpChannel.cpp#1722.

Comment 7

[Michal Novotny [:michal]]

Attachment: fix

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1768de3e9f2
browser/base/content/test/general/browser_save_video.js fails when we enable rcwn, r=honzab

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d1768de3e9f2