1384506 - dom/base/test/test_urgent_start.html fails when we enable rcwn

Status: RESOLVED FIXED

(Core :: Networking: Cache, enhancement)

Description

[Junior [inactive]]

Attachment: addObserver

RCWN would break the test by the following command

mach mochitest --setpref network.http.rcwn.enabled=true dom/base/test/test_urgent_start.html

The reason is the test rely on topic "http-on-examine-response" and "http-on-examine-cached-response"

However, RCWN won't notify both topics if we race.

I found that listening to "http-on-modify-request" could solve the problem.
Is it a reasonable solution, michal?

Comment 1

[Michal Novotny [:michal]]

The test already listens to "http-on-modify-request". I don't understand the test. Honza, you did the review, so why the test expects the entry from the cache? Is that essential for testing urgent-start marking problem? If not, the test could be changed so it avoids using the cache.

Comment 2

[Tom Tung [:tt, :ttung]]

(In reply to Michal Novotny (:michal) from comment #1)
> The test already listens to "http-on-modify-request". I don't understand the
> test. Honza, you did the review, so why the test expects the entry from the
> cache? Is that essential for testing urgent-start marking problem? If not,
> the test could be changed so it avoids using the cache.

I wrote this test to check the urgent-start flag is marked on the channel. 

I guess you are saying already listening to "http-on-examine-response"?

I send a request multiple times to verify it only marked as urgent-start when it is triggered by user input events. I believe the Necko might cache the response so that I can get the channel by listening to "http-on-examine-cached-response".

Comment 3

[Honza Bambas (:mayhemer)]

Honestly I don't understand the test enough to give a feedback here.  Maybe just disable rcwn for this test?  It tests something else than cache anyway.

Comment 4

[Junior [inactive]]

Attachment: disableRcwnDomUrgentStart, v1

disable by last comment

Comment 5

[Tom Tung [:tt, :ttung]]

Comment on attachment 8892724 [details] [diff] [review]
disableRcwnDomUrgentStart, v1

lgtm, thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d03602f141eb
Disable rcwn in test_urgent_start.html. r=tt

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d03602f141eb

Comment 8

[Aki Sasaki (not active)]

https://hg.mozilla.org/projects/date/rev/d03602f141eb7896cc46b243d97d9c2fda6e3413
Bug 1384506 - Disable rcwn in test_urgent_start.html. r=tt