1384510 - toolkit/mozapps/extensions/test/xpcshell/test_backgroundupdate.js fails when we enable rcwn

Status: RESOLVED WORKSFORME

(Core :: Networking: Cache, enhancement, P3)

Description

[Junior [inactive]]

RCWN would break the toolkit/mozapps/extensions/test/xpcshell/test_backgroundupdate.js

STR:
1. Set pref "network.http.rcwn.enabled" to true and
"network.http.rcwn.max_wait_before_racing_ms" to 0
2. run the xpcshell-test

We have some discussion in bug 1373198 comment 29-31
and open this bug for tracking.

The reason of breaking is that the order of |addons-background-update-complete|
and |OnDownloadFailed| are reversed. We need to the causal relationship of RCWN

Comment 1

[Junior [inactive]]

Hello Robert, 

Hope you don't mind I move the discussion to here since bug 1373198 is out of focus.
set the ni since we need your help.

Do you have any idea on comment 0?
Or is it possible to have a minimum test?

Thanks.

Comment 2

[Robert Helmer [:rhelmer]]

(In reply to Junior[:junior] from comment #1)
> Hello Robert, 
> 
> Hope you don't mind I move the discussion to here since bug 1373198 is out
> of focus.
> set the ni since we need your help.
> 
> Do you have any idea on comment 0?
> Or is it possible to have a minimum test?
> 
> Thanks.

Sorry, I missed this being moved out of the previous bug.

Still not sure why this would happen but I'll take a look.

Comment 3

[Michal Novotny [:michal]]

Robert, Junior, what's progress on this bug? It's blocking bug 1392841.

Comment 4

[Junior [inactive]]

Since it's blocking bug 1392841, we'd like to disable the rcwn in this test.
Also, leave the bug open, so we can discuss what we found later.

Comment 5

[Junior [inactive]]

Attachment: disable-rcwn-bgupdate

Comment 6

[Robert Helmer [:rhelmer]]

Comment on attachment 8902631 [details] [diff] [review]
disable-rcwn-bgupdate

Change is fine but I'd really like to understand why this breaks.. I can't seem to make it happen in the real code, just the test so I suspect it has something to do with our test harness / test web server /etc.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba9f215363ba
Disable rcwn in test_backgroundupdate.js. r=rhelmer

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ba9f215363ba

Comment 9

[Firefox Bug Husbandry Bot]

Bulk priority update: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 24 weeks.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:nhi, maybe it's time to close this bug?

Comment 12

[Nhi Nguyen (:nhi)]

Junior, is there anything more to be done for this bug? if not, please close it. Thanks!

Comment 13

[Junior [inactive]]

The test is removed. Thanks!