toolkit/mozapps/extensions/test/xpcshell/test_backgroundupdate.js fails when we enable rcwn

NEW
Assigned to

Status

()

Core
Networking: Cache
P1
normal
3 months ago
15 days ago

People

(Reporter: junior, Assigned: rhelmer)

Tracking

(Blocks: 2 bugs, {leave-open, stale-bug})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [necko-active])

Attachments

(1 attachment)

(Reporter)

Description

3 months ago
RCWN would break the toolkit/mozapps/extensions/test/xpcshell/test_backgroundupdate.js

STR:
1. Set pref "network.http.rcwn.enabled" to true and
"network.http.rcwn.max_wait_before_racing_ms" to 0
2. run the xpcshell-test

We have some discussion in bug 1373198 comment 29-31
and open this bug for tracking.

The reason of breaking is that the order of |addons-background-update-complete|
and |OnDownloadFailed| are reversed. We need to the causal relationship of RCWN
(Reporter)

Comment 1

3 months ago
Hello Robert, 

Hope you don't mind I move the discussion to here since bug 1373198 is out of focus.
set the ni since we need your help.

Do you have any idea on comment 0?
Or is it possible to have a minimum test?

Thanks.
Flags: needinfo?(rhelmer)
(Assignee)

Comment 2

2 months ago
(In reply to Junior[:junior] from comment #1)
> Hello Robert, 
> 
> Hope you don't mind I move the discussion to here since bug 1373198 is out
> of focus.
> set the ni since we need your help.
> 
> Do you have any idea on comment 0?
> Or is it possible to have a minimum test?
> 
> Thanks.

Sorry, I missed this being moved out of the previous bug.

Still not sure why this would happen but I'll take a look.
Assignee: nobody → rhelmer
Flags: needinfo?(rhelmer)
Whiteboard: [necko-active]
(Reporter)

Updated

2 months ago
Blocks: 1392841
Robert, Junior, what's progress on this bug? It's blocking bug 1392841.
Flags: needinfo?(rhelmer)
Flags: needinfo?(juhsu)
(Reporter)

Comment 4

2 months ago
Since it's blocking bug 1392841, we'd like to disable the rcwn in this test.
Also, leave the bug open, so we can discuss what we found later.
Flags: needinfo?(juhsu)
(Reporter)

Comment 5

2 months ago
Created attachment 8902631 [details] [diff] [review]
disable-rcwn-bgupdate
Attachment #8902631 - Flags: review?(rhelmer)
(Assignee)

Comment 6

2 months ago
Comment on attachment 8902631 [details] [diff] [review]
disable-rcwn-bgupdate

Change is fine but I'd really like to understand why this breaks.. I can't seem to make it happen in the real code, just the test so I suspect it has something to do with our test harness / test web server /etc.
Flags: needinfo?(rhelmer)
Attachment #8902631 - Flags: review?(rhelmer) → review+
(Reporter)

Updated

2 months ago
Keywords: checkin-needed, leave-open

Comment 7

2 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba9f215363ba
Disable rcwn in test_backgroundupdate.js. r=rhelmer
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ba9f215363ba
Bulk priority update: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: -- → P1
Keywords: stale-bug
You need to log in before you can comment on or make changes to this bug.