Closed
Bug 1384519
Opened 7 years ago
Closed 7 years ago
Clipboard bar has incorrect padding
Categories
(Firefox for iOS :: General, enhancement, P1)
Tracking
()
RESOLVED
FIXED
Iteration:
1.29
| Tracking | Status | |
|---|---|---|
| fxios | 9.0 | --- |
People
(Reporter: st3fan, Assigned: jhugman)
Details
(Whiteboard: [MobileCore][Papercut][ClipboardBar])
Attachments
(3 files, 1 obsolete file)
|
972.39 KB,
image/png
|
tecgirl
:
ui-review+
|
Details |
|
55 bytes,
text/x-github-pull-request
|
farhan
:
review+
|
Details | Review |
|
223.64 KB,
image/png
|
tecgirl
:
ui-review+
|
Details |
Simulator Screen Shot - iPhone 4s - 2017-09-04 at 19.41.43.png
The bar is either positioned incorrect and clipped, or the padding is off.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → jhugman
Iteration: --- → 1.28
|
||
Updated•7 years ago
|
Iteration: 1.28 → 1.29
Priority: -- → P1
|
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8904327 -
Flags: ui-review?(randersen)
|
|
Assignee | |
Comment 2•7 years ago
|
||
Attachment #8904328 -
Flags: ui-review?(randersen)
|
|
Assignee | |
Comment 3•7 years ago
|
||
Attachment #8904329 -
Flags: review?(fpatel)
|
|
Assignee | |
Updated•7 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 4•7 years ago
|
||
Comment on attachment 8904327 [details]
Simulator Screen Shot - iPhone 4s - 2017-09-04 at 19.41.43.png
We need some padding around the button! If the title is to run into it, we should decrease the type size.|
|
||
Updated•7 years ago
|
Attachment #8904328 -
Flags: ui-review?(randersen) → ui-review+
|
|
Assignee | |
Comment 5•7 years ago
|
||
Attachment #8904327 -
Attachment is obsolete: true
Attachment #8904327 -
Flags: ui-review?(randersen)
Attachment #8904682 -
Flags: ui-review?(randersen)
|
|
Assignee | |
Comment 6•7 years ago
|
||
:tecgirl – this moves into Bug 1363330 territory. I've updated the PR and the screenshot to incorporate that work.
|
|
||
Updated•7 years ago
|
Attachment #8904682 -
Flags: ui-review?(randersen) → ui-review+
|
||
Updated•7 years ago
|
Attachment #8904329 -
Flags: review?(fpatel) → review+
|
|
Assignee | |
Comment 7•7 years ago
|
||
Merged into master.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [MobileCore][Papercut][ClipboardBar] → [MobileCore][Papercut][ClipboardBar][NeedsUplift]
|
Reporter | |
Comment 8•7 years ago
|
||
Uplifted to v9.x
|
|
Reporter | |
Updated•7 years ago
|
Whiteboard: [MobileCore][Papercut][ClipboardBar][NeedsUplift] → [MobileCore][Papercut][ClipboardBar]
You need to log in
before you can comment on or make changes to this bug.
Description
•