Closed Bug 1384581 Opened 7 years ago Closed 7 years ago

CSS error spam in the console: Property contained reference to invalid variable --toolbarbutton-height

Categories

(Firefox :: Theme, enhancement, P1)

55 Branch
enhancement

Tracking

()

RESOLVED FIXED
Firefox 56
Iteration:
56.4 - Aug 1
Tracking Status
firefox56 --- fixed

People

(Reporter: Gijs, Assigned: jaws)

References

Details

(Whiteboard: [reserve-photon-animation])

Attachments

(1 file)

Per comments from :jaws on IRC, we should probably set a default value in CSS.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment on attachment 8890367 [details]
Bug 1384581 - Define a default value for --toolbarbutton-height to prevent CSS errors when the property is applied before the more specific value has been set.

https://reviewboard.mozilla.org/r/161480/#review166782

::: browser/themes/shared/toolbarbutton-icons.inc.css:6
(Diff revision 1)
>  :root {
>    --toolbarbutton-icon-fill: #4c4c4c;
>    --toolbarbutton-icon-fill-inverted: #fff;
>    --toolbarbutton-icon-fill-attention: #177ee5;
> +  /* This default value of --toolbarbutton-height is defined to prevent
> +     CSS errors for an invalid variable. The valus should not get used,

value

::: browser/themes/shared/toolbarbutton-icons.inc.css:8
(Diff revision 1)
>    --toolbarbutton-icon-fill-inverted: #fff;
>    --toolbarbutton-icon-fill-attention: #177ee5;
> +  /* This default value of --toolbarbutton-height is defined to prevent
> +     CSS errors for an invalid variable. The valus should not get used,
> +     as a more specific value should be set when the value will be used. */
> +  --toolbarbutton-height: 0;

I think the blocks in toolbarbuttons.inc.css (rather than -icons.inc.css) is a more appropriate place for this, as it has other sizing information. :-)
Attachment #8890367 - Flags: review?(gijskruitbosch+bugs) → review+
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [reserve-photon-animation]
Iteration: --- → 56.4 - Aug 1
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dff1bf7903c2
Define a default value for --toolbarbutton-height to prevent CSS errors when the property is applied before the more specific value has been set. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/dff1bf7903c2
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Flags: qe-verify? → qe-verify-
You need to log in before you can comment on or make changes to this bug.