1384581 - CSS error spam in the console: Property contained reference to invalid variable --toolbarbutton-height

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement, P1)

Description

[:Gijs (out for now; he/him)]

Per comments from :jaws on IRC, we should probably set a default value in CSS.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1384581 - Define a default value for --toolbarbutton-height to prevent CSS errors when the property is applied before the more specific value has been set.

Review commit: https://reviewboard.mozilla.org/r/161480/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/161480/

Comment 2

[:Gijs (out for now; he/him)]

Comment on attachment 8890367 [details]
Bug 1384581 - Define a default value for --toolbarbutton-height to prevent CSS errors when the property is applied before the more specific value has been set.

https://reviewboard.mozilla.org/r/161480/#review166782

::: browser/themes/shared/toolbarbutton-icons.inc.css:6
(Diff revision 1)
>  :root {
>    --toolbarbutton-icon-fill: #4c4c4c;
>    --toolbarbutton-icon-fill-inverted: #fff;
>    --toolbarbutton-icon-fill-attention: #177ee5;
> +  /* This default value of --toolbarbutton-height is defined to prevent
> +     CSS errors for an invalid variable. The valus should not get used,

value

::: browser/themes/shared/toolbarbutton-icons.inc.css:8
(Diff revision 1)
>    --toolbarbutton-icon-fill-inverted: #fff;
>    --toolbarbutton-icon-fill-attention: #177ee5;
> +  /* This default value of --toolbarbutton-height is defined to prevent
> +     CSS errors for an invalid variable. The valus should not get used,
> +     as a more specific value should be set when the value will be used. */
> +  --toolbarbutton-height: 0;

I think the blocks in toolbarbuttons.inc.css (rather than -icons.inc.css) is a more appropriate place for this, as it has other sizing information. :-)

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8890367 [details]
Bug 1384581 - Define a default value for --toolbarbutton-height to prevent CSS errors when the property is applied before the more specific value has been set.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161480/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dff1bf7903c2
Define a default value for --toolbarbutton-height to prevent CSS errors when the property is applied before the more specific value has been set. r=Gijs

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dff1bf7903c2