Closed
Bug 1384589
Opened 8 years ago
Closed 8 years ago
Document where the luminescence calculation for -moz-win-accentcolortext comes from
Categories
(Core :: Widget: Win32, enhancement)
Core
Widget: Win32
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
Details
Attachments
(1 file)
|
1.25 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1379266 +++
In bug 1379266 comment 10 Mark noted that he found that MS have a guideline in the Universal Windows Platform documentation for the luminescence calculation that should be used to determine whether light or dark text should be used over the accent color. (Thanks, Mark!) Dao then landed a patch that uses that formula.
We should also update the documenting comment in the code to note where the formula comes from rather than using it without explanation.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8890377 -
Flags: review?(jmathies)
|
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8890377 [details] [diff] [review]
patch
Review of attachment 8890377 [details] [diff] [review]:
-----------------------------------------------------------------
r=whitespace
Attachment #8890377 -
Flags: review?(jmathies) → review+
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc5069b2dacd
Document where the luminescence calculation for -moz-win-accentcolortext comes from. r=jimm
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
||
Comment 5•8 years ago
|
||
https://hg.mozilla.org/projects/date/rev/fc5069b2dacd9656a1f12acb410382cfb98f5866
Bug 1384589 - Document where the luminescence calculation for -moz-win-accentcolortext comes from. r=jimm
You need to log in
before you can comment on or make changes to this bug.
Description
•