Closed Bug 1384654 Opened 3 years ago Closed 3 years ago

The arrows in the overflow panel animation point right instead of left on RTL builds

Categories

(Firefox :: Toolbars and Customization, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 56
Iteration:
56.4 - Aug 1
Tracking Status
firefox-esr52 --- unaffected
firefox54 --- unaffected
firefox55 --- unaffected
firefox56 --- fixed

People

(Reporter: itiel_yn8, Assigned: jaws)

References

(Blocks 1 open bug)

Details

(Whiteboard: [reserve-photon-animation])

Attachments

(2 files)

Attached image Demonstration
Environment:
Windows 10 x86
Nightly 56.0a1 RTL (2017-07-26)

STR:
1. On RTL Nightly, add an icon to the overflow panel
2. Observe its animation

At the end on the animation (right before it changes to the static arrows icon), the arrows point to the right instead to the left, as it would be expected on RTL builds.
Additionally, the static icon appears to be smaller than the one in the animation.

See demo attached.
Whiteboard: [photon-animation][triage]
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Iteration: --- → 56.4 - Aug 1
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [photon-animation][triage] → [reserve-photon-animation]
Comment on attachment 8892025 [details]
Bug 1384654 - Horizontally flip the 'pin to overflow' animation during the fade out when in RTL.

https://reviewboard.mozilla.org/r/163028/#review168326

::: browser/themes/shared/toolbarbutton-icons.inc.css:399
(Diff revision 2)
>    width: 1278px;
>  }
>  
>  #nav-bar-overflow-button[animate]:-moz-locale-dir(rtl) > .toolbarbutton-animatable-box > .toolbarbutton-animatable-image {
>    animation-name: overflow-animation-rtl;
> +  transform: scaleX(-1);

Either put this in a new rule specific to [fade] or add a comment explaining this is redundant with the transform in the animation except for when the animation gets replaced by the fade animation once the fade happens.
Attachment #8892025 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/992636ea8646
Horizontally flip the 'pin to overflow' animation during the fade out when in RTL. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/992636ea8646
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Fixed on latest Nightly.
Status: RESOLVED → VERIFIED
Flags: qe-verify?
Summary: The arrows in the overflow panel animation point right instead of left on RTL builds → The arrows in the overflow panel animation point left instead of right on RTL builds
Summary: The arrows in the overflow panel animation point left instead of right on RTL builds → The arrows in the overflow panel animation point right instead of left on RTL builds
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.