The arrows in the overflow panel animation point right instead of left on RTL builds

VERIFIED FIXED in Firefox 56

Status

()

Firefox
Toolbars and Customization
P1
normal
VERIFIED FIXED
29 days ago
7 days ago

People

(Reporter: ItielMaN, Assigned: jaws)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 56
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox54 unaffected, firefox55 unaffected, firefox56 fixed)

Details

(Whiteboard: [reserve-photon-animation])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

29 days ago
Created attachment 8890441 [details]
Demonstration

Environment:
Windows 10 x86
Nightly 56.0a1 RTL (2017-07-26)

STR:
1. On RTL Nightly, add an icon to the overflow panel
2. Observe its animation

At the end on the animation (right before it changes to the static arrows icon), the arrows point to the right instead to the left, as it would be expected on RTL builds.
Additionally, the static icon appears to be smaller than the one in the animation.

See demo attached.

Updated

29 days ago
Whiteboard: [photon-animation][triage]

Updated

26 days ago
Blocks: 1375152
status-firefox54: --- → unaffected
status-firefox55: --- → unaffected
status-firefox56: --- → affected
status-firefox-esr52: --- → unaffected
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Updated

24 days ago
Iteration: --- → 56.4 - Aug 1
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [photon-animation][triage] → [reserve-photon-animation]
Comment hidden (mozreview-request)

Comment 3

24 days ago
mozreview-review
Comment on attachment 8892025 [details]
Bug 1384654 - Horizontally flip the 'pin to overflow' animation during the fade out when in RTL.

https://reviewboard.mozilla.org/r/163028/#review168326

::: browser/themes/shared/toolbarbutton-icons.inc.css:399
(Diff revision 2)
>    width: 1278px;
>  }
>  
>  #nav-bar-overflow-button[animate]:-moz-locale-dir(rtl) > .toolbarbutton-animatable-box > .toolbarbutton-animatable-image {
>    animation-name: overflow-animation-rtl;
> +  transform: scaleX(-1);

Either put this in a new rule specific to [fade] or add a comment explaining this is redundant with the transform in the animation except for when the animation gets replaced by the fade animation once the fade happens.
Attachment #8892025 - Flags: review?(gijskruitbosch+bugs) → review+
Comment hidden (mozreview-request)

Comment 5

24 days ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/992636ea8646
Horizontally flip the 'pin to overflow' animation during the fade out when in RTL. r=Gijs

Comment 6

23 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/992636ea8646
Status: ASSIGNED → RESOLVED
Last Resolved: 23 days ago
status-firefox56: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
(Reporter)

Comment 7

23 days ago
Fixed on latest Nightly.
Status: RESOLVED → VERIFIED

Updated

23 days ago
Flags: qe-verify?
(Reporter)

Updated

18 days ago
Summary: The arrows in the overflow panel animation point right instead of left on RTL builds → The arrows in the overflow panel animation point left instead of right on RTL builds
(Reporter)

Updated

18 days ago
Summary: The arrows in the overflow panel animation point left instead of right on RTL builds → The arrows in the overflow panel animation point right instead of left on RTL builds
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.