mach check-spidermonkey dies running config/check_spidermonkey_style.py

RESOLVED FIXED in Firefox 56

Status

Firefox Build System
General
RESOLVED FIXED
10 months ago
3 months ago

People

(Reporter: jimb, Assigned: gps)

Tracking

unspecified
mozilla56
x86_64
Linux

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

10 months ago
When I run 'mach check-spidermonkey', when it gets to the check_spidermonkey_style.py step, it fails for me as follows:

(I commented out the earlier steps, running jit-tests, jstests, and jsapi-tests. I hope those don't have necessary side effects.)

shibui:dbg$ mach check-spidermonkey 
running check-style
Traceback (most recent call last):
  File "/home/jimb/moz/dbg/config/check_spidermonkey_style.py", line 45, in <module>
    from mozversioncontrol import get_repository_from_env
ImportError: No module named mozversioncontrol
running check-masm
Traceback (most recent call last):
  File "/home/jimb/moz/dbg/config/check_macroassembler_style.py", line 30, in <module>
    from mozversioncontrol import get_repository_from_env
ImportError: No module named mozversioncontrol
running check-js-msg-encoding
Traceback (most recent call last):
  File "/home/jimb/moz/dbg/config/check_js_msg_encoding.py", line 17, in <module>
    from mozversioncontrol import get_repository_from_env
ImportError: No module named mozversioncontrol
Error running mach:

    ['check-spidermonkey']

The error occurred in the implementation of the invoked mach command.

This should never occur and is likely a bug in the implementation of that
command. Consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

NameError: global name 'jittest_result' is not defined

  File "/home/jimb/moz/dbg/testing/mach_commands.py", line 448, in run_checkspidermonkey
    all_passed = jittest_result and jstest_result and jsapi_tests_result and check_style_result and check_masm_result and check_js_msg_result
(Assignee)

Comment 1

10 months ago
This is fallout from recent work of mine. I'll code up a fix.
Assignee: nobody → gps
Status: NEW → ASSIGNED
Depends on: 1377216
Comment hidden (mozreview-request)
(Assignee)

Comment 3

10 months ago
Also, that NameError in your error output has me perplexed. The static analyzer in my brain tells me that can't occur with the current code. Were you hacking up code in testing/mach_commands.py?
(Assignee)

Comment 4

10 months ago
Oh, your initial comment mentions commenting out. So, yes.
Comment hidden (mozreview-request)
(Reporter)

Comment 6

10 months ago
mozreview-review
Comment on attachment 8890634 [details]
Bug 1384665 - Use virtualenv Python in `mach check-spidermonkey`;

https://reviewboard.mozilla.org/r/161784/#review167122

More carefully choosing the Python interpreter seems like a clear win.
Attachment #8890634 - Flags: review?(jimb) → review+

Comment 7

10 months ago
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/54f3aaacf9e6
Use virtualenv Python in `mach check-spidermonkey`; r=jimb

Comment 8

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/54f3aaacf9e6
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56

Updated

3 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.