1384682 - Bookmarking - There should be On Click feedback in the bookmark icon

Status: RESOLVED WONTFIX

(Firefox :: Bookmarks & History, defect)

Description

[Amy Lee [:amylee] UX]

When the user triggers OnClick the bookmark star icon should turn blue. OnRelease the star burst animation should happen. Please see animation video for reference. 

Thanks!

Animation video: https://drive.google.com/file/d/0B0tdos8pQ1T7eE1KNGlJcF9BSnc/view

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Hi Amy, the animation video you posted is for Pocket, not bookmarking. Did you intend to post one specific to Bookmarks?

Comment 2

[Amy Lee [:amylee] UX]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #1)
> Hi Amy, the animation video you posted is for Pocket, not bookmarking. Did
> you intend to post one specific to Bookmarks?

Hi, 

Sorry, here's the correct video https://drive.google.com/file/d/0B0tdos8pQ1T7QnRmM3FZbU1Ddk0/view

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

From the looks of the video, the bookmark icon should start the animation on mousedown instead of on click.

Note that the only buttons on the default toolbarset that act this way are the bookmarks menu button and the Firefox menu. The library button only opens on mouseup.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

@Amy, how do you feel about comment #3? What about other buttons on the toolbar? Do you want them all to get activated on mousedown? On OSX that would interfere with dragging the window. It also doesn't give users the ability to cancel the click by mousing away before releasing the mouse button.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Perhaps I'm misunderstanding what you mean by "OnClick" and "OnRelease" in comment #0. "onclick" and "mouseup" will always happen one right after the other. Also, the animation you've provided doesn't allow us to do the fill in one motion and then the burst in another motion. The burst animation includes the fill, I don't think we can segment it out without redoing how the animation works.

Comment 6

[Amy Lee [:amylee] UX]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #5)
> Perhaps I'm misunderstanding what you mean by "OnClick" and "OnRelease" in
> comment #0. "onclick" and "mouseup" will always happen one right after the
> other. Also, the animation you've provided doesn't allow us to do the fill
> in one motion and then the burst in another motion. The burst animation
> includes the fill, I don't think we can segment it out without redoing how
> the animation works.

Hi Jared, 

Yeah the original intent was on mouse down the star turns blue and OnRelease the star burst. Right now it feels like there is a slight delay after the user clicks the bookmark star but from what you said it sounds like a lot of work to redo the animation to function this way.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Closing as wontfix since this would change the semantics of how the bookmark button works.