1384697 - Keefox addon breaks session restore

Status: RESOLVED INVALID

(Firefox :: Session Restore, defect)

Description

[nailyk]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170613225334

Steps to reproduce:

1. Setup firefox to open tabs on next launch, setup an home page
2. Install keefox addon, 
3. Pin some tabs, let some other opened, 
4. Close nightly, 
5. Launch nightly. 

Tested on nightly 2017-07-26 (version before the 'restart to update nightly' was fine) but testing this with mozregress is not really relevant. 
IIRC last known good version was 2017-07-24.


Actual results:

All tabs are blanks, except the 'active one while closing' who now display the default page. 


Expected results:

Tabs are restored.

Comment 1

[nailyk]

Forget to say I tested on 2 debian 8 amd 64.

Into console: 
console.error: 
  Message: TypeError: access to strict mode caller function is censored
  Stack:
    NS_ASSERT@resource://gre/modules/debug.js:50:7
restoreTab@resource:///modules/sessionstore/SessionStore.jsm:3594:5
restoreTabs@resource:///modules/sessionstore/SessionStore.jsm:3581:7
ssi_restoreWindow@resource:///modules/sessionstore/SessionStore.jsm:3410:7
ssi_restoreWindows@resource:///modules/sessionstore/SessionStore.jsm:3526:5
initializeWindow@resource:///modules/sessionstore/SessionStore.jsm:1157:11
onBeforeBrowserWindowShown/<@resource:///modules/sessionstore/SessionStore.jsm:1306:9
promise callback*onBeforeBrowserWindowShown@resource:///modules/sessionstore/SessionStore.jsm:1291:5
ssi_observe@resource:///modules/sessionstore/SessionStore.jsm:758:9
onLoad@chrome://browser/content/browser.js:1359:5
onload@chrome://browser/content/browser.xul:1:1

Comment 2

[Kohei Yoshino [:kohei]]

Please report the issue to the extension author.