1384799 - Cannot copy text from the preferences if the page is not focused first

Status: NEW

(Firefox :: Settings UI, defect, P5)

Description

[Ralf Jung]

Steps to reproduce:
* Go to preferences, scroll to the updater section
* Select the version number
* Hit Ctrl-C

Expected behavior:
The version number ends up in the clipboard.

Actual behavior:
Nothing happens.

I had to try this multiple times until I realized that it really does not copy this any more (and it's not just me hitting the wrong key).  Letting me select text and then making it non-copyable is somewhat mean. ;)
This is a regression compared to last week when the updater preferences were on their own tab.

This is with nightly 2017-07-26 (64bit, Linux).

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1384799 - Allow the version string in Preferences to be selected and copied.

Review commit: https://reviewboard.mozilla.org/r/180022/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180022/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8908401 [details]
Bug 1384799 - Allow the version string in Preferences to be selected and copied.

https://reviewboard.mozilla.org/r/180022/#review185212

::: browser/themes/shared/incontentprefs/preferences.inc.css:735
(Diff revision 1)
> +#version {
> +  -moz-user-focus: normal;
> +  cursor: text;
> +}

Should we include the pre/post strings?

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

I'm not sure what you mean by the pre/post strings. This allows selection and copy of "57.0a1 (2017-09-13) (64-bit)" on my local install of Nightly. Are you looking for things like distribution channel names?

Comment 4

[:Gijs (he/him)]

(In reply to (Away until Sept 19) Jared Wein [:jaws] (please needinfo? me) from comment #3)
> I'm not sure what you mean by the pre/post strings. This allows selection
> and copy of "57.0a1 (2017-09-13) (64-bit)" on my local install of Nightly.
> Are you looking for things like distribution channel names?

I assumed this was for https://dxr.mozilla.org/mozilla-central/rev/f9a5e9ed62103c84e4cde915f4d08f1ce71be83e/browser/components/preferences/in-content/main.xul#754 . That has "Version: " in English, and probably other stuff in other locales. I thought if we were going to do this, we should make all of it selectable (maybe not the 'what's new' link, but hey). Does that make sense?

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

This patch matches the behavior of the About window which doesn't have a "Version: " prefix.

Comment 6

[:Gijs (he/him)]

Comment on attachment 8908401 [details]
Bug 1384799 - Allow the version string in Preferences to be selected and copied.

https://reviewboard.mozilla.org/r/180022/#review185894

Clearing review again per comments on IRC.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

So this actually already works, but it only works if the Preferences document has focus.

If you click on the location bar, then drag-select some text in the preferences, Ctrl+C won't copy the selected text (the selection should appear with a grey background). If you then Tab to the document, and perform the same drag-select ctrl+c combination, the selected text will have a blue background and will be copied to the clipboard.