Cannot copy text from the preferences if the page is not focused first

NEW
Unassigned

Status

()

Firefox
Preferences
P5
normal
5 months ago
3 months ago

People

(Reporter: Ralf Jung, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [photon-preference])

Attachments

(1 obsolete attachment)

(Reporter)

Description

5 months ago
Steps to reproduce:
* Go to preferences, scroll to the updater section
* Select the version number
* Hit Ctrl-C

Expected behavior:
The version number ends up in the clipboard.

Actual behavior:
Nothing happens.

I had to try this multiple times until I realized that it really does not copy this any more (and it's not just me hitting the wrong key).  Letting me select text and then making it non-copyable is somewhat mean. ;)
This is a regression compared to last week when the updater preferences were on their own tab.

This is with nightly 2017-07-26 (64bit, Linux).
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Priority: -- → P5
Comment hidden (mozreview-request)

Comment 2

3 months ago
mozreview-review
Comment on attachment 8908401 [details]
Bug 1384799 - Allow the version string in Preferences to be selected and copied.

https://reviewboard.mozilla.org/r/180022/#review185212

::: browser/themes/shared/incontentprefs/preferences.inc.css:735
(Diff revision 1)
> +#version {
> +  -moz-user-focus: normal;
> +  cursor: text;
> +}

Should we include the pre/post strings?
Attachment #8908401 - Flags: review?(gijskruitbosch+bugs)
I'm not sure what you mean by the pre/post strings. This allows selection and copy of "57.0a1 (2017-09-13) (64-bit)" on my local install of Nightly. Are you looking for things like distribution channel names?
Flags: needinfo?(gijskruitbosch+bugs)

Comment 4

3 months ago
(In reply to (Away until Sept 19) Jared Wein [:jaws] (please needinfo? me) from comment #3)
> I'm not sure what you mean by the pre/post strings. This allows selection
> and copy of "57.0a1 (2017-09-13) (64-bit)" on my local install of Nightly.
> Are you looking for things like distribution channel names?

I assumed this was for https://dxr.mozilla.org/mozilla-central/rev/f9a5e9ed62103c84e4cde915f4d08f1ce71be83e/browser/components/preferences/in-content/main.xul#754 . That has "Version: " in English, and probably other stuff in other locales. I thought if we were going to do this, we should make all of it selectable (maybe not the 'what's new' link, but hey). Does that make sense?
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(jaws)
This patch matches the behavior of the About window which doesn't have a "Version: " prefix.
Flags: needinfo?(jaws)
Attachment #8908401 - Flags: review?(gijskruitbosch+bugs)

Comment 6

3 months ago
mozreview-review
Comment on attachment 8908401 [details]
Bug 1384799 - Allow the version string in Preferences to be selected and copied.

https://reviewboard.mozilla.org/r/180022/#review185894

Clearing review again per comments on IRC.
Attachment #8908401 - Flags: review?(gijskruitbosch+bugs)
So this actually already works, but it only works if the Preferences document has focus.

If you click on the location bar, then drag-select some text in the preferences, Ctrl+C won't copy the selected text (the selection should appear with a grey background). If you then Tab to the document, and perform the same drag-select ctrl+c combination, the selected text will have a blue background and will be copied to the clipboard.
Assignee: jaws → nobody
Status: ASSIGNED → NEW
Summary: Cannot copy-paste version number from preferences → Cannot copy text from the preferences if the page is not focused first
Whiteboard: [photon-preference][triage]
Attachment #8908401 - Attachment is obsolete: true

Updated

3 months ago
Whiteboard: [photon-preference][triage] → [photon-preference]
You need to log in before you can comment on or make changes to this bug.