Closed
Bug 1384856
Opened 7 years ago
Closed 7 years ago
Mac: Tools Menu always shows "Sign In To Sync..." in BookMark Library window
Categories
(Firefox :: Sync, defect, P2)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: wiwang, Assigned: tcsc)
References
Details
Attachments
(1 file)
I feel confused:
When I click the menu: "Bookmarks -> show all bookmarks", a new window is opened;
Then if I click menu: "Tools" of that new window, I will see "Sign In To Sync...", but I had already sign in.
I expect to see "Sync Now" as the original window shows.
Did I miss something?
OS: Mac OS X 10.12
Version: Nighlty 56.0a1 (20170726100322)
Not sure here is the right component to file, please help to move if needed :)
Comment 1•7 years ago
|
||
Thanks for the report - I suspect this has been missed for a while since most other platforms don't have a menu for that window. We'll investigate.
Summary: Menu shows "Sign In To Sync..." in a firefox which was already sign in → Mac: Tools Menu always shows "Sign In To Sync..." in BookMark Library window
Updated•7 years ago
|
Priority: -- → P3
Comment 2•7 years ago
|
||
Just a guess: could this be because we don't load `browser-sync.js` into `places.xul` when we open the organizer? (https://searchfox.org/mozilla-central/rev/dca019c94bf3a840ed7ff50261483410cfece24f/browser/base/content/browser-places.js#716-717, https://searchfox.org/mozilla-central/source/browser/components/places/content/places.xul)
Priority: P3 → P2
Assignee | ||
Comment 4•7 years ago
|
||
This also appears on the about dialog ("Firefox Nightly" > "About Nightly" for nightly users), and the page info dialog (Tools > Page Info).
The solution to each of these is probably to add gSync.init() to their initialization functions, but to be honest, I'm not sure this makes sense for the others...
Comment 5•7 years ago
|
||
(In reply to Thom Chiovoloni [:tcsc] from comment #4)
> This also appears on the about dialog ("Firefox Nightly" > "About Nightly"
> for nightly users), and the page info dialog (Tools > Page Info).
I think the right thing to do is work out the best way to remove/hide them in those windows.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → tchiovoloni
Comment hidden (mozreview-request) |
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8943331 [details]
Bug 1384856 - Fix sync menu items showing incorrect state on mac
https://reviewboard.mozilla.org/r/213666/#review219424
LGTM thanks!
Attachment #8943331 -
Flags: review?(eoger) → review+
Comment hidden (mozreview-request) |
Pushed by tchiovoloni@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0c7a34d13dc3
Fix sync menu items showing incorrect state on mac r=eoger
Comment 10•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in
before you can comment on or make changes to this bug.
Description
•