Closed Bug 1384862 Opened 7 years ago Closed 7 years ago

Update woff2 code to latest upstream

Categories

(Core :: Graphics: Text, defect)

Product:
Core
Component:
Graphics: Text
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: Sylvestre, Assigned: jfkthame)

References

Details

Attachments

(1 file, 2 obsolete files)

Update WOFF2 code to latest upstream
23.69 KB, patch
Sylvestre
: review+
Details | Diff | Splinter Review
Fixes some warnings, renaming of variables, additional checks
No longer blocks: build-gcc-7
Does this build successfully? It looks to me like it may depend on a Brotli update...
it builds for me, I just started a try build
Here's a version of the WOFF2 update patch, rebased on top of the Brotli patch in bug 1340910; looks like this should build OK. Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3045a4c7dd33573e005cf747cfab0cac7663999.
Attachment #8891668 - Flags: review?(sledru)
Assignee: sledru → jfkthame
Status: NEW → ASSIGNED
Depends on: 1340910
Attachment #8891668 - Flags: review?(sledru) → review+
Attachment #8890758 - Attachment is obsolete: true
Comment on attachment 8890759 [details] Bug 1384862 - Update the woff2 README (patch no longer existing) https://reviewboard.mozilla.org/r/161952/#review168680 Right, this is gone.
Attachment #8890759 - Flags: review+
Merge is done, let's land that!
Keywords: checkin-needed
We need bug 1340910 to land before this. I'm about to update the patch there...
Keywords: checkin-needed
oh, my bad. sorry :(
https://hg.mozilla.org/mozilla-central/rev/0dc9284b03d4
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Attachment #8890759 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: