Closed
Bug 1384869
Opened 7 years ago
Closed 7 years ago
Fix ImageCompositeNotification when WebRender is enabled
Categories
(Core :: Graphics: WebRender, defect)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(1 file, 3 obsolete files)
6.86 KB,
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
ImageCompositeNotification is not connected when WebRender is enabled. It needs to be addressed.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8890764 -
Attachment is obsolete: true
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8890787 -
Attachment is obsolete: true
Assignee | ||
Comment 4•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a3fcf635c6227f9ac9aa40a4af0bedea07b66954
Assignee | ||
Updated•7 years ago
|
Attachment #8890804 -
Flags: review?(nical.bugzilla)
Comment 5•7 years ago
|
||
Comment on attachment 8890804 [details] [diff] [review] patch - Fix ImageCompositeNotification when WebRender is enabled Review of attachment 8890804 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/wr/WebRenderCompositableHolder.h @@ +84,5 @@ > + { > + mImageCompositeNotifications.AppendElement(aNotification); > + } > + > + void ExtractImageCompositeNotifications(nsTArray<ImageCompositeNotificationInfo>* aNotifications) nit: for some reason I read this the other way around: "this extracts notification from aNotifications". How about "FlushImageNotifications"? ::: gfx/layers/wr/WebRenderImageHost.cpp @@ +168,5 @@ > + mAsyncRef.mHandle, > + img->mTimeStamp, mWrBridge->CompositableHolder()->GetCompositionTime(), > + img->mFrameID, img->mProducerID); > + mWrBridge->CompositableHolder()->AppendImageCompositeNotification(info); > + printf_stderr("WebRenderImageHost::GetAsTextureHostForComposite() if (mAsyncRef) \n"); Need to remove this printf before landing.
Attachment #8890804 -
Flags: review?(nical.bugzilla) → review+
Assignee | ||
Comment 6•7 years ago
|
||
(In reply to Nicolas Silva [:nical] from comment #5) > Comment on attachment 8890804 [details] [diff] [review] > patch - Fix ImageCompositeNotification when WebRender is enabled > > Review of attachment 8890804 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: gfx/layers/wr/WebRenderCompositableHolder.h > @@ +84,5 @@ > > + { > > + mImageCompositeNotifications.AppendElement(aNotification); > > + } > > + > > + void ExtractImageCompositeNotifications(nsTArray<ImageCompositeNotificationInfo>* aNotifications) > > nit: for some reason I read this the other way around: "this extracts > notification from aNotifications". How about "FlushImageNotifications"? I'll update it in a next patch. > > ::: gfx/layers/wr/WebRenderImageHost.cpp > @@ +168,5 @@ > > + mAsyncRef.mHandle, > > + img->mTimeStamp, mWrBridge->CompositableHolder()->GetCompositionTime(), > > + img->mFrameID, img->mProducerID); > > + mWrBridge->CompositableHolder()->AppendImageCompositeNotification(info); > > + printf_stderr("WebRenderImageHost::GetAsTextureHostForComposite() if (mAsyncRef) \n"); > > Need to remove this printf before landing. Oh, I forgot to remove it. I'll update it in a next patch.
Assignee | ||
Comment 7•7 years ago
|
||
Attachment #8890804 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Attachment #8891861 -
Flags: review+
Assignee | ||
Comment 8•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a3f52de5d0bd03f3d0e2c23637cb4e4adade72e4
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/748a817e823e Fix ImageCompositeNotification when WebRender is enabled r=nical
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/748a817e823e
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•