Update snack-bar when editing folders

VERIFIED FIXED in Firefox 58

Status

()

Firefox for Android
General
VERIFIED FIXED
11 months ago
8 months ago

People

(Reporter: sorina, Assigned: jwu, NeedInfo)

Tracking

(Blocks: 1 bug)

56 Branch
Firefox 58
ARM
Android
Points:
---

Firefox Tracking Flags

(fennec+, firefox56- disabled, firefox57+ disabled, firefox58 verified)

Details

(Whiteboard: [FNC][SPT58.1][INT])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

11 months ago
Environment: 
Device: Motorola Nexus 6 (Android 7.0);
Build: Nightly 56.0a1 (2017-07-26);

Steps to reproduce:
1. Launch Fennec and make a new folder A;
2. Long tap on it and choose Edit;
3. Change the name and tap on save button.

Expected result:
A snack-bar is displayed on bottom of the screen with the message "Folder updated". 

Actual result:
A snack-bar is displayed on bottom of the screen with the message "Bookmark updated".

Comment 1

11 months ago
Hi :jwu,

Would you help to check on this bug, please? Thanks
tracking-firefox57: --- → ?
Flags: needinfo?(topwu.tw)
(Assignee)

Comment 2

11 months ago
No problem, this bug would be fixed in 57 nightly since bookmark management is pref-off in 56.
Assignee: nobody → topwu.tw
Flags: needinfo?(topwu.tw)
(Assignee)

Updated

11 months ago
tracking-fennec: ? → +

Comment 3

10 months ago
Moving the tracking nom to 56, I am assuming that was the intention. If it isn't fixed by the time 56 goes live, we can also track it for 57.
status-firefox57: --- → affected
tracking-firefox56: --- → ?
tracking-firefox57: ? → ---

Comment 4

10 months ago
Per comment #2, since bookmark management is pref-off in 56, this bug won't happen in 56. Mark 56 as disabled. After discussing with dev, the feature is only enabled in nightly.
status-firefox56: affected → disabled
tracking-firefox56: ? → -
tracking-firefox57: --- → ?

Comment 5

10 months ago
Tracked for 57. Hi Vance, will this feature ride the 57 train?
tracking-firefox57: ? → +
Flags: needinfo?(vchen)
(Assignee)

Comment 6

10 months ago
This bug is bookmark management related, which is disabled in 57 because of some sync issues. As I know, for now bookmark management is scheduled to be enabled in 58.
status-firefox57: affected → disabled
Comment hidden (mozreview-request)

Comment 8

9 months ago
mozreview-review
Comment on attachment 8913069 [details]
Bug 1384870 - Show 'Folder updated' in snack bar after editing a bookmark folder.

https://reviewboard.mozilla.org/r/184474/#review189638
Attachment #8913069 - Flags: review?(cnevinchen) → review+

Comment 9

9 months ago
Pushed by topwu.tw@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/fe21efcf224e
Show 'Folder updated' in snack bar after editing a bookmark folder. r=nechen

Comment 10

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fe21efcf224e
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
(Reporter)

Comment 11

8 months ago
Verified as fixed in build 58.0a1 (2017-10-11);
Devices: Google Pixel (Android 8.0) and Sony Xperia Z5 Premium (Android 6.0.1).
"Folder updated" is displayed when editing a folder.
status-firefox58: fixed → verified

Updated

8 months ago
Whiteboard: [FNC][SPT58.1][INT]
(Reporter)

Updated

8 months ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.