1384870 - Update snack-bar when editing folders

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sorina Florean [:sflorean]]

Environment: 
Device: Motorola Nexus 6 (Android 7.0);
Build: Nightly 56.0a1 (2017-07-26);

Steps to reproduce:
1. Launch Fennec and make a new folder A;
2. Long tap on it and choose Edit;
3. Change the name and tap on save button.

Expected result:
A snack-bar is displayed on bottom of the screen with the message "Folder updated". 

Actual result:
A snack-bar is displayed on bottom of the screen with the message "Bookmark updated".

Comment 1

[Max Liu [:maliu]]

Hi :jwu,

Would you help to check on this bug, please? Thanks

Comment 2

[Jing-wei Wu [:jwu]]

No problem, this bug would be fixed in 57 nightly since bookmark management is pref-off in 56.

Comment 3

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Moving the tracking nom to 56, I am assuming that was the intention. If it isn't fixed by the time 56 goes live, we can also track it for 57.

Comment 4

[Gerry Chang [:gchang]]

Per comment #2, since bookmark management is pref-off in 56, this bug won't happen in 56. Mark 56 as disabled. After discussing with dev, the feature is only enabled in nightly.

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked for 57. Hi Vance, will this feature ride the 57 train?

Comment 6

[Jing-wei Wu [:jwu]]

This bug is bookmark management related, which is disabled in 57 because of some sync issues. As I know, for now bookmark management is scheduled to be enabled in 58.

Comment 7

[Jing-wei Wu [:jwu]]

Attachment: Bug 1384870 - Show 'Folder updated' in snack bar after editing a bookmark folder.

Review commit: https://reviewboard.mozilla.org/r/184474/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184474/

Comment 8

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8913069 [details]
Bug 1384870 - Show 'Folder updated' in snack bar after editing a bookmark folder.

https://reviewboard.mozilla.org/r/184474/#review189638

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe21efcf224e
Show 'Folder updated' in snack bar after editing a bookmark folder. r=nechen

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fe21efcf224e

Comment 11

[Sorina Florean [:sflorean]]

Verified as fixed in build 58.0a1 (2017-10-11);
Devices: Google Pixel (Android 8.0) and Sony Xperia Z5 Premium (Android 6.0.1).
"Folder updated" is displayed when editing a folder.