Open
Bug 1384889
Opened 7 years ago
Updated 2 years ago
symbolstore.py doesn't map file paths back from $(DIST)/include when the header is a GENERATED_FILE
Categories
(Toolkit :: Crash Reporting, enhancement)
Toolkit
Crash Reporting
Tracking
()
NEW
People
(Reporter: ted, Unassigned)
References
Details
Looking at the list of files that wind up in our symbol files in bug 1384568, I noticed that there were a couple of header files listed in dist/include. symbolstore.py has code to read the install manifest for dist/include and use it to map files from there back to their original source locations: https://dxr.mozilla.org/mozilla-central/rev/7d2e89fb92331d7e4296391213c1e63db628e046/toolkit/crashreporter/tools/symbolstore.py#323 However, for GENERATED_FILES that are in EXPORTS, the emitter just uses `add_optional_exists`, so it doesn't actually record any information about where those files came from: https://dxr.mozilla.org/mozilla-central/rev/7d2e89fb92331d7e4296391213c1e63db628e046/python/mozbuild/mozbuild/backend/recursivemake.py#1399 It would be nice to figure out a way to track this so that once we're uploading the generated source files we can map these dist/include paths to the right place.
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•