Closed
Bug 1384893
Opened 7 years ago
Closed 7 years ago
Add-on post-install notification shouldn't use --toolbarbutton-icon-fill nor menuPanel.svg
Categories
(Firefox :: Theme, enhancement, P1)
Firefox
Theme
Tracking
()
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
(Whiteboard: [photon-visual])
Attachments
(1 file)
--toolbarbutton-icon-fill only makes sense in toolbars and menuPanel.svg is going to go away.
Assignee | ||
Updated•7 years ago
|
Flags: qe-verify-
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Iteration: --- → 56.4 - Aug 1
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8890807 [details] Bug 1384893 - Avoid using --toolbarbutton-icon-fill and menuPanel.svg in the add-on post-install notification. https://reviewboard.mozilla.org/r/162014/#review168290 Seems good. This (obviously) changes the color of the icons to the text color but I'd say that actually improves things.
Attachment #8890807 -
Flags: review?(jhofmann) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3cad3569c8b9 Avoid using --toolbarbutton-icon-fill and menuPanel.svg in the add-on post-install notification. r=johannh
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3cad3569c8b9
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in
before you can comment on or make changes to this bug.
Description
•