Closed Bug 1384908 Opened 7 years ago Closed 7 years ago

Crash in nsGlobalWindow::ObserveStorageNotification

Categories

(Core :: DOM: Core & HTML, defect)

56 Branch
Unspecified
Linux
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox-esr52 --- unaffected
firefox54 --- unaffected
firefox55 --- unaffected
firefox56 --- fixed

People

(Reporter: calixte, Assigned: baku)

References

(Blocks 1 open bug)

Details

(Keywords: crash, regression, topcrash, Whiteboard: [clouseau])

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-60bef9f9-43af-4908-a31c-0a9460170727.
=============================================================

There are 4 crashes (from the same installation) in nightly 56 with buildid 20170727100240. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1379568.
The MOZ_CRASH reason is MOZ_RELEASE_ASSERT(IsPrivateBrowsing() == aPrivateBrowsing).

[1] https://hg.mozilla.org/mozilla-central/rev?node=a3efdf436e9577b4472a468b0189b7743a9cfcf4
Flags: needinfo?(amarchesini)
Attached patch fix.patchSplinter Review
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Attachment #8890855 - Flags: review?(bugs)
Attachment #8890855 - Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/795aeb51da2b
nsGlobalWindow::ObserveStorageNotification should check if the private browsing state has changed, r=asuth
This signature is ranked #2 in content top-crashers.
Keywords: topcrash
https://hg.mozilla.org/mozilla-central/rev/795aeb51da2b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.