1384941 - [mac] remove access to mach services which are for cameras

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, enhancement, P1)

Description

[Alex Gaynor [:Alex_Gaynor]]

We remoted cameras, so now any mach services which exist to support them can be removed (we removed the dedicated |device-camera| permission a while ago).

Comment 1

[Alex Gaynor [:Alex_Gaynor]]

Attachment: Bug 1384941 - removed access to mach services which are used for cameras in the content process;

Review commit: https://reviewboard.mozilla.org/r/162082/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/162082/

Comment 2

[Alex Gaynor [:Alex_Gaynor]]

Try job: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ecbb149387af79149cbfacdde6fe39004f3cd4f&group_state=expanded

Local testing I did to make sure stuff didn't break:

1) WebRTC with a USB microphone
2) WebRTC with a USB camera
3) Normal audio (youtube) with a USB headset

Are there other cases that'd be useful to manually test?

Comment 3

[Alex Gaynor [:Alex_Gaynor]]

Another thing I tested:

4) WebRTC with screen capture.

Comment 4

[Haik Aftandilian [:haik]]

Comment on attachment 8890862 [details]
Bug 1384941 - removed access to mach services which are used for cameras in the content process;

https://reviewboard.mozilla.org/r/162082/#review167480

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78d41229c339
removed access to mach services which are used for cameras in the content process; r=haik

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/78d41229c339