138495 - Hard-Linking with FontMgr Lib doesn't work on 8.6 w/ CW 7.2

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Conrad Carlen (not reading bugmail)]

From bug 136311:

------ Additional Comment #31 From Simon Fraser 2002-04-18 16:56 -------

Talked to brade online about this. The problem now is that gfxComponent is
hard-linking against the FontManager lib, which is not present in 8.6 (even
though we do TVector tests in code to make sure it's present). I belive this
changed because CW 7.0 had a bug that caused all OS symbols to be weak linked,
which was fixed in 7.2 (so they are now hard-linked).

Because we link with FontManagerLib via InterfacesStubs, we can't just set weak
linkage there (it doesn't carry through). So we need to remove FontManagerLib
from Interfaces.mcp, add it to gfxComponent.mcp, and weak link with it there.
Kathy has tested this, and it works.

Comment 1

[Kathleen :Brade]

Attachment: patch

Comment 2

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 79997 [details] [diff] [review]
patch

tried the patch on OSX. works fine, as expected. verified the targets used by
osx are not affected by these changes.

r=pink

Comment 3

[Conrad Carlen (not reading bugmail)]

Comment on attachment 79997 [details] [diff] [review]
patch

r=ccarlen

Comment 4

[Simon Fraser [no longer active]]

Comment on attachment 79997 [details] [diff] [review]
patch

sr=sfraser

Comment 5

[Simon Fraser [no longer active]]

Seeing this makes me wonder about other symbols we weak-link against. I bet we
no longer run on non-PCI machines, because JS links against SleepQInstall.

http://lxr.mozilla.org/seamonkey/search?string=kUnresolvedCFragSymbolAddress

(now beard should he happy that I made him use kUnresolvedCFragSymbolAddress,
because we can search for it).

Comment 6

[Benjamin Mucci]

Non-pci machines are probably not fast enough to (properly) run Moz anyway.

Anyway System Requirements for Mac

    * Mac OS 8.5 or later
    * PowerPC 604e 266 MHz or faster processor, or G3/G4

Comment 7

[Kathleen :Brade]

nominate for adt1.0.0 consideration
This is a must have if we want to continue to support OS 8.5.x and OS 8.6.x on
Macintosh.

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 79997 [details] [diff] [review]
patch

a=[e-mail] for branch checkin

Comment 9

[scottputterman]

adding adt1.0.0+.  Please checkin to the branch as soon as possible and add the
fixed1.0.0 keyword.

Comment 10

[Kathleen :Brade]

Fixed on both trunk and branch; we'll try to keep trunk working a bit longer but
at some point we won't support 8.x on the trunk.

Comment 11

[Kathleen :Brade]

*** Bug 139076 has been marked as a duplicate of this bug. ***

Comment 12

[Brad Tiffany]

*** Bug 141917 has been marked as a duplicate of this bug. ***

Comment 13

[Brad Tiffany]

*** Bug 140424 has been marked as a duplicate of this bug. ***

Comment 14

[Brad Tiffany]

*** Bug 142539 has been marked as a duplicate of this bug. ***