1384974 - Activity Stream re-enables the "Recommended by Pocket" section

Status: RESOLVED WORKSFORME

(Firefox :: New Tab Page, defect, P3)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Previous to today's Nightly 56.0a1 (2017-07-27) (64-bit) build, I had the "Recommended by Pocket" section disabled on the New Tab page.

After update to today's build, the section has re-appeared. I'm guessing something wasn't correct with migration code?

I'm on Windows 10 and haven't shared my profile with other builds.

Comment 1

[Ed Lee :Mardak]

The pocket section was only just enabled by default in bug 1384807, so if you had seen it before, you probably turned it on and then off.

When you're talking about "migration code" are you talking about something from before activity-stream or across versions of activity-stream?

I would assume this is what happened to your prefs state:
before bug 1384807: default pocket pref false
you enabled: user set pref true
you disabled: user set pref false (i.e., cleared, back to default)
after bug 1384807: default pocket pref true

Comment 2

[Ed Lee :Mardak]

From irc: i'm betting pref() was used when it should have been sticky_pref()

That sounds likely given the prep state changes described in comment 1.

> you disabled: user set pref false (i.e., cleared, back to default)

`sticky_pref` would have kept the pref set to false instead of clearing.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

That is correct. I enabled then disabled. sticky_pref would have prevented this bug.

Comment 4

[Ed Lee :Mardak]

Looks like here is where sticky prefs are checked to save user pref or not:
https://searchfox.org/mozilla-central/source/modules/libpref/prefapi.cpp#801-805

Not entirely sure how we get the sticky flag set from JS..

Comment 5

[Ed Lee :Mardak]

This was only an issue when the prefs were being implemented and defaults changed on nightly.