Permanent failure on Cedar: browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/toolbarbutton-dropdown-arrow.png should have been shown.

RESOLVED FIXED in Firefox 56

Status

()

Firefox
General
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

unspecified
Firefox 56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Snipped from the log:

[task 2017-07-27T16:12:13.793518Z] 16:12:13     INFO - TEST-START | browser/base/content/test/performance/browser_startup_images.js
[task 2017-07-27T16:12:13.894996Z] 16:12:13     INFO - TEST-INFO | started process screentopng
[task 2017-07-27T16:12:15.084661Z] 16:12:15     INFO - TEST-INFO | screentopng: exit 0
[task 2017-07-27T16:12:15.086749Z] 16:12:15     INFO - Buffered messages logged at 16:12:13
[task 2017-07-27T16:12:15.087054Z] 16:12:15     INFO - Entering test bound 
[task 2017-07-27T16:12:15.088441Z] 16:12:15     INFO - TEST-FAIL | browser/base/content/test/performance/browser_startup_images.js | Whitelisted image chrome://browser/skin/fxa/sync-illustration.svg should not have been shown. - 
[task 2017-07-27T16:12:15.091306Z] 16:12:15     INFO - TEST-FAIL | browser/base/content/test/performance/browser_startup_images.js | Whitelisted image chrome://browser/skin/tabbrowser/tab-background-end.png should not have been shown. - 
[task 2017-07-27T16:12:15.093298Z] 16:12:15     INFO - TEST-FAIL | browser/base/content/test/performance/browser_startup_images.js | Whitelisted image chrome://browser/skin/tabbrowser/tab-background-middle.png should not have been shown. - 
[task 2017-07-27T16:12:15.098165Z] 16:12:15     INFO - TEST-FAIL | browser/base/content/test/performance/browser_startup_images.js | Whitelisted image chrome://browser/skin/tabbrowser/tab-background-start.png should not have been shown. - 
[task 2017-07-27T16:12:15.100077Z] 16:12:15     INFO - TEST-FAIL | browser/base/content/test/performance/browser_startup_images.js | Whitelisted image chrome://browser/skin/tabbrowser/tabDragIndicator.png should not have been shown. - 
[task 2017-07-27T16:12:15.102103Z] 16:12:15     INFO - TEST-FAIL | browser/base/content/test/performance/browser_startup_images.js | Whitelisted image chrome://browser/skin/arrow-left.svg should not have been shown. - 
[task 2017-07-27T16:12:15.114962Z] 16:12:15     INFO - TEST-FAIL | browser/base/content/test/performance/browser_startup_images.js | Whitelisted image chrome://browser/skin/tabbrowser/tab-overflow-indicator.png should not have been shown. - 
[task 2017-07-27T16:12:15.116548Z] 16:12:15     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/tabbrowser/tab-selected-start.svg should have been shown. - 
[task 2017-07-27T16:12:15.117921Z] 16:12:15     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/tabbrowser/tab-stroke-start.png should have been shown. - 
[task 2017-07-27T16:12:15.119291Z] 16:12:15     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/tabbrowser/tab-active-middle.png should have been shown. - 
[task 2017-07-27T16:12:15.122119Z] 16:12:15     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/tabbrowser/tab-selected-end.svg should have been shown. - 
[task 2017-07-27T16:12:15.124058Z] 16:12:15     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/tabbrowser/tab-stroke-end.png should have been shown. - 
[task 2017-07-27T16:12:15.134659Z] 16:12:15     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://global/skin/icons/close.svg should have been shown. - 
[task 2017-07-27T16:12:15.136112Z] 16:12:15     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/tabbrowser/newtab.svg should have been shown. - 
[task 2017-07-27T16:12:15.137565Z] 16:12:15     INFO - TEST-FAIL | browser/base/content/test/performance/browser_startup_images.js | Whitelisted image chrome://browser/skin/arrow-dropdown.svg should not have been shown. - 
[task 2017-07-27T16:12:15.139063Z] 16:12:15     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/back-large.svg should have been shown. - 
[task 2017-07-27T16:12:15.155147Z] 16:12:15     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/forward.svg should have been shown. - 
[task 2017-07-27T16:12:15.156590Z] 16:12:15     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/identity-icon.svg should have been shown. - 
[task 2017-07-27T16:12:15.158012Z] 16:12:15     INFO - TEST-FAIL | browser/base/content/test/performance/browser_startup_images.js | Whitelisted image chrome://browser/skin/tracking-protection-16.svg#enabled should not have been shown. - 
[task 2017-07-27T16:12:15.162782Z] 16:12:15     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/search-indicator.png should have been shown. - 
[task 2017-07-27T16:12:15.164211Z] 16:12:15     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/bookmark-hollow.svg should have been shown. - 
[task 2017-07-27T16:12:15.165635Z] 16:12:15     INFO - TEST-PASS | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/bookmarksMenu.svg should have been shown. - 
[task 2017-07-27T16:12:15.165898Z] 16:12:15     INFO - Buffered messages finished
[task 2017-07-27T16:12:15.167302Z] 16:12:15     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/toolbarbutton-dropdown-arrow.png should have been shown. - 
[task 2017-07-27T16:12:15.167546Z] 16:12:15     INFO - Stack trace:
[task 2017-07-27T16:12:15.168859Z] 16:12:15     INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_startup_images.js:null:204

Example build: https://treeherder.mozilla.org/#/jobs?repo=cedar&revision=d4d5e225250d6a71fa8fe31da16e8142a90caa5f
Comment hidden (obsolete)
This affects Linux, Windows and macOS.
Hey johannh, do you have time to look at this?
Flags: needinfo?(jhofmann)
This regressed with bug 1372689 which removed the non-photon whitelist entry.
Blocks: 1372689
Flags: needinfo?(dao+bmo)

Comment 5

10 months ago
Is this bug about browser_all_files_referenced.js or browser_startup_images.js? The summary and comment 0 say different things.
Flags: needinfo?(dao+bmo)
Bah - bug clone fail on my part. browser_startup_images.js is what's failing. Sorry for the confusion.
Summary: Permanent failure on Cedar: browser/base/content/test/static/browser_all_files_referenced.js | Loaded image chrome://browser/skin/toolbarbutton-dropdown-arrow.png should have been shown. → Permanent failure on Cedar: browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/toolbarbutton-dropdown-arrow.png should have been shown.

Comment 7

10 months ago
I don't understand why toolbarbutton-dropdown-arrow.png would be loaded in non-photon builds.

There's this rule for type="menu-button" toolbarbuttons:
http://searchfox.org/mozilla-central/rev/ad093e98f42338effe2e2513e26c3a311dd96422/browser/themes/shared/toolbarbuttons.inc.css#76-78

And the legacy bookmarks button is such a button, but it has a custom dropdown icon.
I can reproduce this locally. I'll try to find out where it's coming from.
Assignee: nobody → mconley
Flags: needinfo?(jhofmann)
According to rr, the node that's loading this image is indeed bookmarks-menu-button.

Here's the rule that adds the toolbarbutton-dropdown-arrow.png image by default on toolbar buttons with children with the 'toolbarbutton-menubutton-dropmarker' class:

http://searchfox.org/mozilla-central/rev/ad093e98f42338effe2e2513e26c3a311dd96422/browser/themes/shared/toolbarbuttons.inc.css#76-78

and here's the rule that overrides it for bookmarks-menu-button:

http://searchfox.org/mozilla-central/rev/ad093e98f42338effe2e2513e26c3a311dd96422/browser/themes/shared/toolbarbutton-icons.inc.css#199-201

It looks like they're targeting two completely different nodes. I wonder if we've been loading both images in pre-Photon-world, and one's just obscuring the other.
Could we also be slow enough setting the [cui-areatype="toolbar"] attribute such that the first rule still loads the image?
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #10)
> Could we also be slow enough setting the [cui-areatype="toolbar"] attribute
> such that the first rule still loads the image?

I thought about that, but it looks like the node initializes with that attribute set: http://searchfox.org/mozilla-central/rev/ad093e98f42338effe2e2513e26c3a311dd96422/browser/base/content/browser.xul#960-975
Comment hidden (mozreview-request)

Comment 13

10 months ago
mozreview-review
Comment on attachment 8891079 [details]
Bug 1385005 - Put toolbarbutton-dropdown-arrow.png on the non-Photon browser_startup_images.js whitelist.

https://reviewboard.mozilla.org/r/162258/#review167516

Works for me. No use in spending too much time on this.
Attachment #8891079 - Flags: review?(jhofmann) → review+

Comment 14

10 months ago
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a9029a587fec
Put toolbarbutton-dropdown-arrow.png on the non-Photon browser_startup_images.js whitelist. r=johannh

Comment 15

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a9029a587fec
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.