1385164 - Unpaired gfxContext::Save/Restore in BasicLayerManager::PushGroupForLayer

Status: RESOLVED INVALID

(Core :: Web Painting, defect, P2)

Description

[u459114]

gfxContext::Save is called at [1], BasicLayerManager::PushGroupForLayer may exit at [2] without calling gfxContext::Restore

[1] http://searchfox.org/mozilla-central/source/gfx/layers/basic/BasicLayerManager.cpp#95
[2] http://searchfox.org/mozilla-central/source/gfx/layers/basic/BasicLayerManager.cpp#122

Comment 1

[u459114]

Attachment: Bug 1385164 - Using gfxContextAutoSaveRestore to prevent unpaired gfxContext::Save/Restore.

Review commit: https://reviewboard.mozilla.org/r/162368/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/162368/

Comment 2

[u459114]

Comment on attachment 8891170 [details]
Bug 1385164 - Using gfxContextAutoSaveRestore to prevent unpaired gfxContext::Save/Restore.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/162368/diff/1-2/

Comment 3

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8891170 [details]
Bug 1385164 - Using gfxContextAutoSaveRestore to prevent unpaired gfxContext::Save/Restore.

https://reviewboard.mozilla.org/r/162368/#review167642