1385274 - WebAuthnManager asserts when trying to resolve mPBackgroundCreationPromise twice

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, enhancement)

Description

[Tim Taubert [:ttaubert] (inactive)]

Calling WebAuthnManager::GetOrCreateBackgroundActor() twice in a row (i.e. hitting the button on the test page like a maniac) can cause us to call mPBackgroundCreationPromise.Resolve() twice in a row, without an .Ensure() call in between that would refill mPromise. And thus we assert.

As soon as we filled WebAuthnManager::mChild and it sticks around we actually don't need to create another WebAuthnTransactionChild. And we also don't always need to fire a BackgroundChild runnable.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1385274-Don-t-try-to-resolve-WebAuthnManager-mPB.patch

This seems closer to the pattern other PBackground consumers use. And we don't assert anymore.

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1385274-Don-t-try-to-resolve-WebAuthnManager-mPB.patch, v2

Some more cleanup.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee929726e093
Don't try to resolve WebAuthnManager::mPBackgroundCreationPromise twice r=jcj

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ee929726e093