Closed Bug 1385274 Opened 4 years ago Closed 4 years ago
Authn Manager asserts when trying to resolve m PBackground Creation Promise twice
Calling WebAuthnManager::GetOrCreateBackgroundActor() twice in a row (i.e. hitting the button on the test page like a maniac) can cause us to call mPBackgroundCreationPromise.Resolve() twice in a row, without an .Ensure() call in between that would refill mPromise. And thus we assert. As soon as we filled WebAuthnManager::mChild and it sticks around we actually don't need to create another WebAuthnTransactionChild. And we also don't always need to fire a BackgroundChild runnable.
This seems closer to the pattern other PBackground consumers use. And we don't assert anymore.
Some more cleanup.
Attachment #8891351 - Flags: review?(jjones) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/ee929726e093 Don't try to resolve WebAuthnManager::mPBackgroundCreationPromise twice r=jcj
You need to log in before you can comment on or make changes to this bug.