Closed
Bug 1385313
Opened 7 years ago
Closed 7 years ago
Use MozPromiseRequestHolders in U2FTokenManager
Categories
(Core :: DOM: Device Interfaces, enhancement)
Core
DOM: Device Interfaces
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
(Whiteboard: [webauthn])
Attachments
(1 file)
9.62 KB,
patch
|
jcj
:
review+
|
Details | Diff | Splinter Review |
We currently use RefPtrs to track the promises, but that actually isn't the right thing it turns out. We should have MPRHs that track the promises.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8891394 -
Flags: review?(jjones)
Comment 2•7 years ago
|
||
Comment on attachment 8891394 [details] [diff] [review] 0001-Bug-1385313-Use-MozPromiseRequestHolders-in-U2FToken.patch Review of attachment 8891394 [details] [diff] [review]: ----------------------------------------------------------------- This is much cleaner use of the MozPromises, and closely follows the disconnect case from bholley's post [1]. r+ [1] http://bholley.net/blog/2015/mozpromise.html
Attachment #8891394 -
Flags: review?(jjones) → review+
Pushed by ttaubert@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f78bdc8e529b Use MozPromiseRequestHolders in U2FTokenManager r=jcj
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f78bdc8e529b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•