Closed Bug 1385313 Opened 2 years ago Closed 2 years ago

Use MozPromiseRequestHolders in U2FTokenManager

Categories

(Core :: DOM: Device Interfaces, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

(Whiteboard: [webauthn])

Attachments

(1 file)

We currently use RefPtrs to track the promises, but that actually isn't the right thing it turns out. We should have MPRHs that track the promises.
Comment on attachment 8891394 [details] [diff] [review]
0001-Bug-1385313-Use-MozPromiseRequestHolders-in-U2FToken.patch

Review of attachment 8891394 [details] [diff] [review]:
-----------------------------------------------------------------

This is much cleaner use of the MozPromises, and closely follows the disconnect case from bholley's post [1]. r+


[1] http://bholley.net/blog/2015/mozpromise.html
Attachment #8891394 - Flags: review?(jjones) → review+
Pushed by ttaubert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f78bdc8e529b
Use MozPromiseRequestHolders in U2FTokenManager r=jcj
https://hg.mozilla.org/mozilla-central/rev/f78bdc8e529b
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.