1385314 - Video frames aren't displayed if WebRender is enabled with nvidia GPUs on linux

Status: RESOLVED DUPLICATE of bug 1401455

(Core :: Graphics: WebRender, defect, P2)

Description

[Nicolas Silva [:nical]]

Trying to watch a youtube video with webrender enabled on linux (software decoding with YCbCr images and BufferTextureClient/Host), and video frames don't show except while I am scrolling. As soon as I stop scrolling the video disappears.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

That sounds like maybe we're not calling GenerateFrame enough?

Comment 2

[Sotaro Ikeda [:sotaro]]

Hmm, I did not see the problem on youtube on linux with latest source. Can you provide the youtube video link? Did you change the webrender related prefs?

Comment 3

[Nicolas Silva [:nical]]

Not sure what's different between our setups, I tried with and without the webrendest pref as well as "layout.smaller-painted-layers" and I reproduce the issue every time by just going to youtube and watching any video. I just pulled and built a fresh revision of mozilla-central and the issue still reproduces as soon as webrender is enabled.

Comment 4

[Sotaro Ikeda [:sotaro]]

I checked on my several window pcs and linux pcs with latest sources, but I did not see the problem :(

I also tested with nightly with webrender enabled on linux pc, but I did not see the the problem.

Comment 5

[Sotaro Ikeda [:sotaro]]

:nica, can you test again with another linux pc? And also with nightly with webrender enabled?

Comment 6

[Nicolas Silva [:nical]]

I just tested a clean builder on another computer and I have the same issue (both with release and debug builds).

Comment 7

[Sotaro Ikeda [:sotaro]]

(In reply to Nicolas Silva [:nical] from comment #6)
> I just tested a clean builder on another computer and I have the same issue
> (both with release and debug builds).

Hmm, it is wired:( I never saw the symptom. Can you also test with nightly build? Can you provide the actual url of the video?

Comment 8

[Sotaro Ikeda [:sotaro]]

:nical, can you also test with "LIBGL_ALWAYS_SOFTWARE=1 ./mach run"?

Comment 9

[Nicolas Silva [:nical]]

> :nical, can you also test with "LIBGL_ALWAYS_SOFTWARE=1 ./mach run"?

I tried that too, and also tried with a nightly build form the official channels. Same thing, 100% repro on every youtube videos.

It appears to be specific to a combination of YUV + external images or async pipelines + external images.

I changed the condition here: https://searchfox.org/mozilla-central/rev/c329d562fb6c6218bdb79290faaf015467ef89e2/gfx/layers/wr/AsyncImagePipelineManager.cpp#165 so that we always take the else branch and use a regular rgb image for each video frame (but still using async pipelines), and the video plays correctly.

Comment 10

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Is it still reproducible? Could you try with the clear pref setting?
I would like to check this issue.

Comment 11

[Jerry Shih[:jerry] (UTC+8) (inactive)]

I test for today's nightly build with the linux pc, I could see the youtube videos(including the software-decoding webm format) normally. I can't reproduce the issue.
Could you show your test url(combine of YUV + external images or async pipelines + external images)?

Comment 12

[Jerry Shih[:jerry] (UTC+8) (inactive)]

15:43	nical	Jerry_IRCCloud: I just tried again on a freh build and I still have the issue
15:43	nical	on pretty much every youtube video I can find
15:44	nical	like www.youtube.com/watch?v=VQ_KrRq4UiA
15:44	nical	Jerry_IRCCloud: same thing with the video on this page: www.webmfiles.org/demo-files

I try the both links again with today's linux build, the video still looks good.

commit 809dd0e81b5c4e02a25ee098bbc4e4be4a9c3719

Hi nical,
could you please attach your about:support here?

Comment 13

[Nicolas Silva [:nical]]

Attachment: about:support

There we go. This is the about:support for a fresh mozilla-central debug build.

Comment 14

[Nicolas Silva [:nical]]

Interestingly, the bug doesn't reproduce in apitrace replays (it does while recording, but when replay happens video frames are show properly). Could be some state coming from something not recorded by apitrace (some x11 stuff in the widget?) affecting the gl commands, maybe? In any case that rules out one of my earlier theories that the video frame data wasn't getting through to the renderer or that yuv primitives weren't generated.

I tried with yet another linux computer and the issue still happens. The common denominator on all of these machines seems to be nvidia propriterary drivers (different nvidia gpus).

Comment 15

[Nicolas Silva [:nical]]

I tried on another computer with an intel GPU instead of nvidia and it works fine.
The bug still reproduces on both my nvidia computers.

Comment 16

[Sotaro Ikeda [:sotaro]]

:nical, does the problem still happen? I wonder if the problem is addressed by Bug 1401455.

Comment 17

[Nicolas Silva [:nical]]

It's fixed \o/