Closed Bug 1385356 Opened 7 years ago Closed 7 years ago

AddressSanitizer: SEGV on unknown address 0x000000000008 (pc 0x7fcbb1c72b38 bp 0x7fff9fc9d2e0 sp 0x7fff9fc9c8a0 T0) in browser/components/sessionstore/test/browser_tabicon_after_bg_tab_crash.js

Categories

(Firefox :: Session Restore, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: ahal, Assigned: ahal)

References

Details

Attachments

(1 file)

https://treeherder.mozilla.org/logviewer.html#?job_id=118977611&repo=try&lineNumber=2858

We recently discovered ASAN errors weren't turning tasks orange. Upon fixing that, this is one of two permafails. We'll need to either fix or disable this before landing a patch in bug 1385311.
Ah - straight forward. We need to update the rule for the test to only run if the crashreporter is enabled.
Ah, do you think that's also the fix for bug 1385355?
Flags: needinfo?(mconley)
Looks like mccr8 came to the same conclusion.
Flags: needinfo?(mconley)
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Comment on attachment 8892036 [details]
Bug 1385356 - Skip browser_tabicon_after_bg_tab_crash.js and browser_child_resources.js if crashreporter is disabled,

https://reviewboard.mozilla.org/r/163040/#review168332
Attachment #8892036 - Flags: review?(continuation) → review+
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f015aed895e1
Skip browser_tabicon_after_bg_tab_crash.js and browser_child_resources.js if crashreporter is disabled, r=mccr8
Oops, I attached the patch to the bug I duped instead of the one I was duping to..
Resolution: DUPLICATE → FIXED
Assignee: nobody → ahalberstadt
Luckily it looks like there weren't any real problems that slipped in because of this, just needed to skip those two tests that depend on crashreporter.

Here's a good looking try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=02baffe6bc221ba883117d60e92aebee3bb5e85a
You need to log in before you can comment on or make changes to this bug.