Closed Bug 1385368 Opened 7 years ago Closed 7 years ago

Error building DebugGLDrawData::DebugGLDrawData() with static analysis

Categories

(Core :: Graphics: Layers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

0:11.91 In file included from /home/ehsan/moz/src.1347035/obj-ff-dbg/gfx/layers/Unified_cpp_gfx_layers0.cpp:137:
 0:11.91 /home/ehsan/moz/src.1347035/gfx/layers/LayerScope.cpp:631:45: error: Type 'std::list<GLuint>' (aka 'list<unsigned int>') must not be used as parameter
 0:11.91                     const std::list<GLuint> aTexIDs,
 0:11.91                                             ^
 0:11.91 /home/ehsan/moz/src.1347035/gfx/layers/LayerScope.cpp:631:45: note: Please consider passing a const reference instead
 0:11.91 /usr/lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/bits/stl_list.h:503:11: note: 'std::list<GLuint>' (aka 'list<unsigned int>') is a non-param type because it inherits from a non-param type '_List_base<unsigned int, std::allocator<unsigned int> >'
 0:11.91     class list : protected _List_base<_Tp, _Alloc>
 0:11.91           ^
 0:11.91 /usr/lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/bits/stl_list.h:347:18: note: '_List_base<unsigned int, std::allocator<unsigned int> >' is a non-param type because member '_M_impl' is a non-param type 'std::__cxx11::_List_base<unsigned int, std::allocator<unsigned int> >::_List_impl'
 0:11.91       _List_impl _M_impl;
 0:11.91                  ^
 0:11.91 /usr/lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/bits/stl_list.h:327:21: note: 'std::__cxx11::_List_base<unsigned int, std::allocator<unsigned int> >::_List_impl' is a non-param type because member '_M_node' is a non-param type '_List_node<size_t>' (aka '_List_node<unsigned long>')
 0:11.91         _List_node<size_t> _M_node;
 0:11.91                            ^
 0:11.91 /usr/lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/bits/stl_list.h:112:40: note: '_List_node<size_t>' (aka '_List_node<unsigned long>') is a non-param type because member '_M_storage' is a non-param type '__gnu_cxx::__aligned_membuf<unsigned long>'
 0:11.91       __gnu_cxx::__aligned_membuf<_Tp> _M_storage;
 0:11.91                                        ^
 0:11.91 /usr/lib/gcc/x86_64-linux-gnu/6.3.0/../../../../include/c++/6.3.0/ext/aligned_buffer.h:47:12: note: '__gnu_cxx::__aligned_membuf<unsigned long>' is a non-param type because member '_M_storage' has an alignas(_) annotation
 0:11.91     struct __aligned_membuf
 0:11.91            ^
 0:11.91 1 error generated.
Attachment #8891437 - Flags: review?(michael)
Comment on attachment 8891437 [details] [diff] [review]
Pass aTextIDs as a const reference

Review of attachment 8891437 [details] [diff] [review]:
-----------------------------------------------------------------

The fact that we need this static analysis at all is just awful.

This is gross that we have to do it, but lgtm.
Attachment #8891437 - Flags: review?(michael) → review+
Assignee: nobody → ehsan
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5cbc88dede0
Pass aTextIDs as a const reference; r=mystor
https://hg.mozilla.org/mozilla-central/rev/b5cbc88dede0
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.