1385656 - stylo: RecoverLetterFrames doesn't play nicely with ::first-line

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

Something I just realized about the patches from bug 1324619: they don't handle the case when a ::first-letter is created directly inside a ::first-line instead of being wrapped in it.  This happens in RecoverLetterFrames.

Simple testcase:

  <style>
    div { border: 5px solid transparent; }
    div::first-line { }
    div::first-letter { border: inherit; border-color: yellow; }
  </style>
  <div onclick="this.appendChild(document.createTextNode('Does the first letter still have a border?'))">
    Click me.
  </div>

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1385656. Fix the interaction of RecoverLetterFrames and ::first-line.

Review commit: https://reviewboard.mozilla.org/r/167308/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167308/

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 8896036 [details]
Bug 1385656.  Fix the interaction of RecoverLetterFrames and ::first-line.

https://reviewboard.mozilla.org/r/167308/#review172614

(Stealing per bz's request.)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63ebcdc4d3ab
Fix the interaction of RecoverLetterFrames and ::first-line.  r=heycam

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/63ebcdc4d3ab