Libraries are always built in "release" config when building the app

RESOLVED FIXED in Firefox 57

Status

()

Firefox for Android
Build Config & IDE Support
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: JanH, Assigned: JanH)

Tracking

Trunk
Firefox 57
All
Android
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 months ago
... which means that debug info for local variables and the like will be missing for files in "geckoview" respectively "thirdparty".
Comment hidden (mozreview-request)

Comment 2

2 months ago
mozreview-review
Comment on attachment 8891802 [details]
Bug 1385695 - Propagate "app" debug/release build type to dependencies.

https://reviewboard.mozilla.org/r/162796/#review171220

Is this helping when using the debugger?

The only thing I'm not sure about: When we start to actually publish those artifacts via a maven repository then I do not think we want to publish non release artifacts.
(Assignee)

Comment 3

2 months ago
mozreview-review-reply
Comment on attachment 8891802 [details]
Bug 1385695 - Propagate "app" debug/release build type to dependencies.

https://reviewboard.mozilla.org/r/162796/#review171220

When looking at things belonging to Geckoview it definitively helps, so the conflict with the configuration required for Maven is a bit unfortunate.

Not doing this wouldn't be a terrible problem for me though to be honest, as I could simply fold these commits into my private base commit I keep around for mass-rebasing of my patches and occasions like this, but of course that wouldn't help anybody else who might want to properly debug geckoview. On the other hand it seems like I might be the first one to complain about this, so make of that what you will :-)
(Assignee)

Updated

2 months ago
Duplicate of this bug: 1392537
Be aware that release configurations are subtly intertwined with Gecko binaries: http://searchfox.org/mozilla-central/source/mobile/android/gradle/with_gecko_binaries.gradle#22.  At the time that I evaluated it, I concluded that it was not feasible to use release configurations in the way you are suggesting.  But now I don't see why not, and I support this approach in general.

Just be very careful with the Gecko binaries!

nechen: I'll wait on the review from Bug 1392537, and let you all agree what is best here.
Flags: needinfo?(cnevinchen)

Comment 6

2 months ago
I think Jan's patch is better :) Thanks for the help to let all library modules debugger friendly :)
Flags: needinfo?(cnevinchen)

Comment 7

2 months ago
mozreview-review
Comment on attachment 8891802 [details]
Bug 1385695 - Propagate "app" debug/release build type to dependencies.

https://reviewboard.mozilla.org/r/162796/#review178624

If this unblocks debugging then this is okay with me. We can reconcider once we actually distribute builds.
Attachment #8891802 - Flags: review?(s.kaspari) → review+
(Assignee)

Comment 8

2 months ago
(In reply to Nick Alexander :nalexander [parental leave until September 15th] from comment #5)
> Just be very careful with the Gecko binaries!

Hmm, I hope this try run is enough of a good sign that this didn't mess up things too badly:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=18c89fcebeb8f9b327b8d1084c9bef7ce9e178e6
(In reply to Jan Henning [:JanH] from comment #8)
> (In reply to Nick Alexander :nalexander [parental leave until September
> 15th] from comment #5)
> > Just be very careful with the Gecko binaries!
> 
> Hmm, I hope this try run is enough of a good sign that this didn't mess up
> things too badly:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=18c89fcebeb8f9b327b8d1084c9bef7ce9e178e6

I triggered the Robocop jobs for moz.build and Gradle -- that actually runs the APK, including trying to load the Gecko binaries.  None of the other tests actually start Gecko :)
(Assignee)

Comment 10

2 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd5cda1860c222113d67787a40570a75afd78c07

Comment 11

2 months ago
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/2f4ec6a1b39e
Propagate "app" debug/release build type to dependencies. r=sebastian
https://hg.mozilla.org/mozilla-central/rev/2f4ec6a1b39e
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.