1385785 - [Form Autofill] Clicking on warning note should not open preferences tab.

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P5)

Description

[Ray Lin[:ralin]]

When user click on warning note, we should do nothing rather than open Preference tab which behaves the same as "more options" button.
Though they are both contained in the same item in current implementation, there should be a distinction between them.

Besides, it's undesirable that "more options" is highlighted when user hover on warning note.

Comment 2

[Ray Lin[:ralin]]

Attachment: Bug 1385785 - Clicking on form autofill dropdown warning notes should not open preferences tab.

Review commit: https://reviewboard.mozilla.org/r/199310/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199310/

Comment 3

[Ray Lin[:ralin]]

Just came across this bug, and a straight fix sprang to mind. Please help me to review it if got some times, no hurry. Thanks!

Comment 4

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8928080 [details]
Bug 1385785 - Clicking on form autofill dropdown warning notes should not open preferences tab.

https://reviewboard.mozilla.org/r/199310/#review204716

Looks good.

Comment 5

[Ray Lin[:ralin]]

Thank you Luke!

(In reply to Ray Lin[:ralin] from comment #0)
> Besides, it's undesirable that "more options" is highlighted when user hover
> on warning note.
I think unexpectedly opening a new tab affect more to looking bad on highlight. Let's land this first, and put this issue to another place for total UI polish.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44e3040ff6e0
Clicking on form autofill dropdown warning notes should not open preferences tab. r=lchang

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/44e3040ff6e0

Comment 8

[Gabi Cheta [:Gabi] Desktop QA]

Verfied as fixed with Windows 10x64, Ubuntu 16.04 and MacOS 10.13.2