|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
When user click on warning note, we should do nothing rather than open Preference tab which behaves the same as "more options" button. Though they are both contained in the same item in current implementation, there should be a distinction between them. Besides, it's undesirable that "more options" is highlighted when user hover on warning note.
Just came across this bug, and a straight fix sprang to mind. Please help me to review it if got some times, no hurry. Thanks!
Status: NEW → ASSIGNED
status-firefox57: --- → wontfix
status-firefox58: --- → fix-optional
status-firefox59: --- → affected
Comment on attachment 8928080 [details] Bug 1385785 - Clicking on form autofill dropdown warning notes should not open preferences tab. https://reviewboard.mozilla.org/r/199310/#review204716 Looks good.
Attachment #8928080 - Flags: review?(lchang) → review+
Thank you Luke! (In reply to Ray Lin[:ralin] from comment #0) > Besides, it's undesirable that "more options" is highlighted when user hover > on warning note. I think unexpectedly opening a new tab affect more to looking bad on highlight. Let's land this first, and put this issue to another place for total UI polish.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/44e3040ff6e0 Clicking on form autofill dropdown warning notes should not open preferences tab. r=lchang
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox59: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Verfied as fixed with Windows 10x64, Ubuntu 16.04 and MacOS 10.13.2
Status: RESOLVED → VERIFIED
status-firefox59: fixed → verified
You need to log in before you can comment on or make changes to this bug.