[Form Autofill] Clicking on warning note should not open preferences tab.

VERIFIED FIXED in Firefox 59

Status

()

P5
normal
VERIFIED FIXED
a year ago
2 months ago

People

(Reporter: ralin, Assigned: ralin)

Tracking

unspecified
mozilla59
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox57 wontfix, firefox58 wontfix, firefox59 verified)

Details

(Whiteboard: [form autofill])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
When user click on warning note, we should do nothing rather than open Preference tab which behaves the same as "more options" button.
Though they are both contained in the same item in current implementation, there should be a distinction between them.

Besides, it's undesirable that "more options" is highlighted when user hover on warning note.
(Assignee)

Updated

a year ago
Blocks: 1329628
(Assignee)

Updated

11 months ago
Duplicate of this bug: 1380315

Updated

9 months ago
Component: Form Manager → Form Autofill
Comment hidden (mozreview-request)
Assignee: nobody → ralin
(Assignee)

Comment 3

9 months ago
Just came across this bug, and a straight fix sprang to mind. Please help me to review it if got some times, no hurry. Thanks!
Status: NEW → ASSIGNED
status-firefox57: --- → wontfix
status-firefox58: --- → fix-optional
status-firefox59: --- → affected

Comment 4

9 months ago
mozreview-review
Comment on attachment 8928080 [details]
Bug 1385785 - Clicking on form autofill dropdown warning notes should not open preferences tab.

https://reviewboard.mozilla.org/r/199310/#review204716

Looks good.
Attachment #8928080 - Flags: review?(lchang) → review+
(Assignee)

Comment 5

9 months ago
Thank you Luke!

(In reply to Ray Lin[:ralin] from comment #0)
> Besides, it's undesirable that "more options" is highlighted when user hover
> on warning note.
I think unexpectedly opening a new tab affect more to looking bad on highlight. Let's land this first, and put this issue to another place for total UI polish.
Keywords: checkin-needed

Comment 6

9 months ago
Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/44e3040ff6e0
Clicking on form autofill dropdown warning notes should not open preferences tab. r=lchang
Keywords: checkin-needed

Comment 7

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/44e3040ff6e0
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox59: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Flags: qe-verify+
Verfied as fixed with Windows 10x64, Ubuntu 16.04 and MacOS 10.13.2
Status: RESOLVED → VERIFIED
status-firefox59: fixed → verified
status-firefox58: fix-optional → wontfix
You need to log in before you can comment on or make changes to this bug.