Fine tune nsDisplaySVGText::Paint

RESOLVED FIXED in Firefox 57

Status

()

enhancement
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: u459114, Assigned: u459114)

Tracking

(Blocks 1 bug)

unspecified
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [qf:p1])

Attachments

(4 attachments, 1 obsolete attachment)

Assignee

Description

2 years ago
No description provided.
Comment hidden (mozreview-request)
Assignee

Comment 4

2 years ago
mozilla::TextRenderedRunIterator::First take time which out of my expectation
Duplicate gfxSave/Restore - I sould find a way to catch all this kind of problem
Status: NEW → ASSIGNED
Priority: -- → P2
Assignee

Updated

2 years ago
Whiteboard: [qf]
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Updated

2 years ago
Whiteboard: [qf] → [qf:p1]
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Attachment #8892039 - Attachment is obsolete: true
Assignee

Updated

2 years ago
Attachment #8891991 - Flags: review?(matt.woodrow)
Attachment #8891992 - Flags: review?(matt.woodrow)
Attachment #8892040 - Flags: review?(matt.woodrow)
Assignee

Updated

2 years ago
Attachment #8891993 - Flags: review?(matt.woodrow)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 25

2 years ago
mozreview-review
Comment on attachment 8891991 [details]
Bug 1385861 - Part 1. Remove redundant gfxContext::Save/Restore in nsDisplaySVGText::Paint.

https://reviewboard.mozilla.org/r/163004/#review169050
Attachment #8891991 - Flags: review?(matt.woodrow) → review+

Comment 26

2 years ago
mozreview-review
Comment on attachment 8891992 [details]
Bug 1385861 - Part 2. Save the state of input context in SVGTextFrame::PaintSVG only when need.

https://reviewboard.mozilla.org/r/163006/#review169052
Attachment #8891992 - Flags: review?(matt.woodrow) → review+

Comment 27

2 years ago
mozreview-review
Comment on attachment 8891993 [details]
Bug 1385861 - Part 3. Rename nsSVGUtils::SetupCairoStrokeGeometry as nsSVGUtils::SetupStrokeGeometry.

https://reviewboard.mozilla.org/r/163008/#review169058
Attachment #8891993 - Flags: review?(matt.woodrow) → review+

Comment 28

2 years ago
mozreview-review
Comment on attachment 8892040 [details]
Bug 1385861 - Part 4. Reduce usage of SetMatrix in SVGTextFrame::PaintSVG.

https://reviewboard.mozilla.org/r/163044/#review169062
Attachment #8892040 - Flags: review?(matt.woodrow) → review+

Comment 29

2 years ago
Pushed by cku@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/615e94f1555b
Part 1. Remove redundant gfxContext::Save/Restore in nsDisplaySVGText::Paint. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/e8c4ad3acfd0
Part 2. Save the state of input context in SVGTextFrame::PaintSVG only when need. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/61072ea18a88
Part 3. Rename nsSVGUtils::SetupCairoStrokeGeometry as nsSVGUtils::SetupStrokeGeometry. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/5d10630d73e2
Part 4. Reduce usage of SetMatrix in SVGTextFrame::PaintSVG. r=mattwoodrow
You need to log in before you can comment on or make changes to this bug.