Closed Bug 1385869 Opened 7 years ago Closed 7 years ago

Ensure that FxA change email does not break Pocket integration

Categories

(Cloud Services :: Server: Firefox Accounts, defect)

Product:
Cloud Services
Component:
Server: Firefox Accounts
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: vbudhram, Assigned: vbudhram)

References

Details

The main components for allowing a user to change their primary email in FxA has landed in our test environment and is available to @mozilla emails as an opt-in feature. From original conversation with Pocket, they said that they use the FxA uid for tracking users and that there should minimal changes on their side to support it. This bug will be used to track any Pocket specific changes or updates needed for change email.
Once the feature is in production on the FxA servers, we'll be able to share instructions how to enable it for initial testing. I guess the right approach then is for the engineers on the pocket side to create some test accounts, try changing their FxA email address, and see what happens downstream in Pocket. Matt, does this sound reasonable?
Flags: needinfo?(matt)
Apologies for the delay responding - I've been on vacation. I'm back in the office next Wednesday, August 9th and have flagged this to follow-up. Is there a final summary somewhere that you can point me to of the changes being implemented? I'll review and follow-up - but yes, once we have instructions on how to test, we can make sure things are setup properly on our end. I'll leave the needinfo flag for time being until I can circle back.
Vijay, once train-93 goes live with this available for testing, can you please provide instructions here for how Matt can test it out? > Is there a final summary somewhere that you can point me to of the changes being implemented? Basically, users can go to https://accounts.firefox.com/ and add new email addresses to their account, delete old ones, and change which address is considered "primary". We haven't implemented any mechanism to tell downstream reliers (like Pocket) when such a change happens, but you will notice it in one of two ways: * If a user does a fresh sign in to pocket via FxA, you'll see that login have the same FxA uid as before, but a different email address. * If you use an existing OAuth token for an existing user to fetch their latest profile data, you will receive the new primary email address.
Flags: needinfo?(vbudhram)
> Is there a final summary somewhere that you can point me to of the changes being implemented? Sure, steps can be found here https://docs.google.com/spreadsheets/d/1OqvelS1Kdfq5kZop026BH7FbOeqbwfRSLGgG4oPWe4Y/edit#gid=0 Currently, secondary emails and change primary email is only available to @mozilla email but once train-93 you can use any email. On that note, I tested pocket with my mozilla email after I changed primary email. > If a user does a fresh sign in to pocket via FxA, you'll see that login have the same FxA uid as before, but a different email address. This was not the case, Pocket navigation bar shows the old primary email. However, all of my previously saved items are still there and everything looks like it is working properly.
Flags: needinfo?(vbudhram)
Vijay: I just requested access to that Google Spreadsheet. Can you please grant?
Access granted, also here is a SUMO article draft that might be helpful as well. https://docs.google.com/a/mozilla.com/document/d/1SFrP2DxZj23uFUfWVQBAYutEhoEricJLTqfcJmSO1PQ/edit?usp=sharing
Vijay: I wanted to follow-up here. Is this available to test now? If not, any chance we could enable ability to test with @getpocket.com emails?
Flags: needinfo?(matt) → needinfo?(vbudhram)
Hey Matt, It is available now but still behind a feature flag while we wait for some client code to land. The steps below should work * Log into FxA with @getpocket.com * Add and verify secondary email * From FxA settings, append `canChangeEmail=true` to url, refresh page * From here will see an option to make your secondary email the new primary Currently, you can only make verified secondary emails into your account's new primary email. Let me know if you have any trouble.
Flags: needinfo?(vbudhram)
> * Add and verify secondary email Also note that currently, you can only do this if you're signed in to sync in the browser, because it needs the special session-verification feature that's only available through sync.
> from Sync fest testing: > Pocket will create a new account for the user if they change their primary email. Ref: https://github.com/mozilla/fxa-bugzilla-mirror/issues/350#issuecomment-330642185
Flags: needinfo?(matt)
Matt, I just tested this out and Pocket doesn't handle the email change properly. Pocket creates a new account for the user after they change their primary email in FxA.
(oops, looks like Vlad and I posted at same time)
Vlad, Alex: This is expected as the fix on our end hasn't been pushed live. It looks like we can test now with @getpocket.com per instructions above - we will do so and circle back when this is live. I'm at new hire onboarding this week, so this will likely be a next week release. If that's a big problem, please advise and I can see what I can do to get it out sooner.
> I'm at new hire onboarding this week, so this will likely be a next week release. No problem, we can't put this live for all users until after Firefox 57 at the earliest, so plenty of time on your side :-)
Flags: needinfo?(matt)
> No problem, we can't put this live for all users until after Firefox 57 at the earliest A quick update here, at this stage it looks like we're on track to make this change available to all users once Firefox 57 is out the door, so targeting a release sometime mid-November. Matt, does that timeline sound OK from your side?
Flags: needinfo?(matt)
Ryan: Sounds good. I dropped this down our priority slightly since its not in 57, but won't be a problem to sort it out this month. I'll circle back when we have something that can be tested.
Hi Matt, I hope your various Firefox 57 preparations are going well :-) Any update on this one?
Ryan: We actually spoke about this during sprint planning last week and teed up for this upcoming sprint (which started last week and runs through first week of December). Is there any update on your end in terms of timing for launch? Still looking at mid-November? If yes, I'll prioritize earlier in the sprint.
Flags: needinfo?(matt) → needinfo?(rfkelly)
> Is there any update on your end in terms of timing for launch? Still looking at mid-November? Yep, we're still looking to switch this on mid-to-late November, once Firefox 57 is out and stable and has seen significant rollout.
Flags: needinfo?(rfkelly)
Just confirming that we're good to go on our side now that 57 is successfully out. Matt, I'm restoring the ni? here for an update whenever things are ready on you side.
Flags: needinfo?(matt)
Hi Matt, any update on this one? Let me know if you want to catch up in person during the all-hands to discuss.
Blocks: 1364676
No longer depends on: 1364676
Hi Matt, Happy New Year! Any updates on this one?
Flags: needinfo?(matt)
Flags: needinfo?(matt)
Ryan - happy new year to you as well. Yes, we will have this live this week. Will ping back when it is live and ready for testing on your end.
Flags: needinfo?(matt)
Ryan - Thanks for your patience with this. Happy to report that we pushed live an update on our end that should properly handle Firefox Account email changes. With the new update, if you change your Firefox Accounts email, you will still be logged into the same Pocket account (vs. a new account being created). We've confirmed this is working on Web and Mobile - but, of course, would be good to get your team to take a look as well. Let us know if you need anything else here.
Thanks Matt! I tried it out and things seem to work as I'd expect. The primary email displayed by pocket remains the old primary email from FxA, but I think that's likely OK and users will realize what's happened. Vijay, do you want to do any further testing here?
Flags: needinfo?(vbudhram)
Ryan: Cool glad it worked as expected. The primary email remaining the same is as expected - lots of complexity if we start messing with that and unclear if it should change based on an update from an "external" service. Something we can track and revisit if we are seeing user confusion.
> The primary email remaining the same is as expected - lots of complexity if we start messing with that > and unclear if it should change based on an update from an "external" service. Yep, 100% agree.
> Vijay, do you want to do any further testing here? Give it a try and works as you described. I don't believe there are any further testing needed.
Flags: needinfo?(vbudhram)
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.