1385952 - Remove usage of Preferences.jsm from PushService and PushServiceWebsocket

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P3)

Description

[Marco Castelluccio [:marco]]

In bug 1357517, we are removing/delaying Preferences.jsm usage until the "before handling user events" phase (the module is now loaded in this phase).

We should try to load it even later, possibly adding it to the "before becoming idle" blaklist.

Comment 1

[Marco Castelluccio [:marco]]

The first step would be to move Preferences.jsm to be loaded "before becoming idle", in order to do that, we need to remove its usage from:
dom/push/PushService.jsm
dom/push/PushServiceWebSocket.jsm
browser/extensions/activity-stream/lib/ActivityStreamPrefs.jsm

The last one is a bit problematic, as it exposes a new class extending Preferences which is used by other ActivityStream code. This module is a really small wrapper around Preferences.jsm, I suppose we could get rid of it altogether (which would also help with bug 1350472).

Comment 2

[Emma Malysz]

Attachment: Bug 1385952, Remove usage of Preferences.jsm from PushService and PushServiceWebsocket in order to load preferences before becoming idle

Comment 3

[Ed Lee :Mardak]

Just documenting some discussion from elsewhere…

ActivityStreamPrefs does extend Preferences.jsm class mainly using .get() and .set() methods and ._prefBranch getter to expose .observeBranch() and .ignoreBranch() helpers similar to Preferences.jsm's .observe() but for all prefs instead of a single pref.

ActivityStream.jsm specifies a prefs object that contains various pref types, so the dynamic int vs string vs bool pref behavior is desired. But potentially this code could be removed in favor of using plain firefox.js prefs in the common case (while still specially changing behavior based on browser.search.region).

Overall, because this is quite a bit more work than simply inlining Preferences.get() -> Services.prefs.getStringPref(), the ActivityStreamPrefs changes probably want to be split out to a separate bug.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7ab41d7d5f7
Remove usage of Preferences.jsm from PushService and PushServiceWebsocket in order to load preferences before becoming idle r=mconley

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d7ab41d7d5f7