Open Bug 1385989 Opened 3 years ago Updated 3 years ago
Consider not rejecting if `History
.insert Many` doesn't add any new items
(In reply to Kit Cambridge (he/him) [:kitcambridge] (UTC-7) from comment #0) > > Bob, I think you originally implemented `insertMany`. Would you be OK with > changing the behavior? Yes, that would be fine for my use of `insertMany`. I notice that the docs for insertMany say that it will throw an error if any URLs are encountered which should not be added to history , which sounds like it would be an issue for your use case, but I don't actually see that implemented in the code anywhere. It would be interesting to know if that's a bug in the docs or in the method.  http://searchfox.org/mozilla-central/rev/09c065976fd4f18d4ad764d7cb4bbc684bf56714/toolkit/components/places/History.jsm#240-242
I'm fine relaxing this. So basically it will never reject.
You need to log in before you can comment on or make changes to this bug.