Closed Bug 1386094 Opened 4 years ago Closed 1 year ago

Avoid using branchValueIsNurseryCell when some of {object,string,bigint} are not possible

Categories

(Core :: JavaScript Engine: JIT, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: sfink, Assigned: jandem)

References

Details

Attachments

(1 file)

In bug 903519 comment 56, visitPostWriteBarrierCommonV always tests masm.branchValueIsNurseryCell, but jandem points out that most uses will know something about the types of Value possible.
Priority: -- → P3
Depends on: 1442481

Updated description to handle bigints, assuming we'll be nursery-allocating them soon.

Depends on: 1530372
Summary: Avoid using branchValueIsNurseryCell when one of {object,string} is not possible → Avoid using branchValueIsNurseryCell when some of {object,string,bigint} are not possible

Hi Jan, is this issue still valid after bug 1636916?

If it's no longer valid, we should also remove this comment in CodeGenerator.cpp:

// Bug 1386094 - most callers only need to check for object, string, or
// bigint, not all three.

Flags: needinfo?(jdemooij)

(In reply to André Bargull [:anba] from comment #2)

Hi Jan, is this issue still valid after bug 1636916?

If it's no longer valid, we should also remove this comment in CodeGenerator.cpp:

// Bug 1386094 - most callers only need to check for object, string, or
// bigint, not all three.

Thanks for noticing. I'll post a patch to remove that comment.

Flags: needinfo?(jdemooij)
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/de5cc94eb739
Remove a comment that no longer applies after bug 1636916. r=anba DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.