1386094 - Avoid using branchValueIsNurseryCell when some of {object,string,bigint} are not possible

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P3)

Description

[Steve Fink [:sfink] [:s:]]

In bug 903519 comment 56, visitPostWriteBarrierCommonV always tests masm.branchValueIsNurseryCell, but jandem points out that most uses will know something about the types of Value possible.

Comment 1

[Steve Fink [:sfink] [:s:]]

Updated description to handle bigints, assuming we'll be nursery-allocating them soon.

Comment 2

[André Bargull [:anba]]

Hi Jan, is this issue still valid after bug 1636916?

If it's no longer valid, we should also remove this comment in CodeGenerator.cpp:

// Bug 1386094 - most callers only need to check for object, string, or
// bigint, not all three.

Comment 3

[Jan de Mooij [:jandem]]

(In reply to André Bargull [:anba] from comment #2)

Hi Jan, is this issue still valid after bug 1636916?

If it's no longer valid, we should also remove this comment in CodeGenerator.cpp:

// Bug 1386094 - most callers only need to check for object, string, or
// bigint, not all three.

Thanks for noticing. I'll post a patch to remove that comment.

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1386094 - Remove a comment that no longer applies after bug 1636916. r?anba! DONTBUILD

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de5cc94eb739
Remove a comment that no longer applies after bug 1636916. r=anba DONTBUILD

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/de5cc94eb739